imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
element-portable/src/components/views/dialogs
History
Travis Ralston 8db7766a40
Add safety to the spotlight search dialog (#9177) 
* Add safety to the spotlight search dialog

Fixes https://github.com/vector-im/element-web/issues/22851

This test was triggering the mentioned bug only occasionally because it was dependent on when the search settled: if it settled early then the length was wrong. In testing, the dialog was caught multiple times to have passed the length chat but update to show duplicated results before the test closed the client, indicating a race condition within the tests.

To fix this, we just make sure everything settles before moving on. We do this on unaffected tests too to ensure they don't regress later.

The affected test was "should find group DMs by usernames or user ids".

* Update cypress/e2e/spotlight/spotlight.spec.ts

Co-authored-by: Robin <robin@robin.town>

Co-authored-by: Robin <robin@robin.town>
2022-08-11 22:26:25 +00:00
..
devtools Make sonar happier (#9114) 2022-07-29 11:01:15 +00:00
security Device manager - device security recommendation card (PSG-637) (#9158) 2022-08-11 10:39:14 +00:00
spotlight Add safety to the spotlight search dialog (#9177) 2022-08-11 22:26:25 +00:00
AddExistingSubspaceDialog.tsx fix merge conflict resolution issue 2021-07-29 15:24:42 +01:00
AddExistingToSpaceDialog.tsx Space panel accessibility improvements (#9157) 2022-08-10 12:14:54 +00:00
AnalyticsLearnMoreDialog.tsx Remove dead code (#9035) 2022-07-11 07:52:44 +02:00
AppDownloadDialog.tsx Make percy snapshots for user onboarding more reliable (#9132) 2022-08-08 13:17:04 +02:00
AskInviteAnywayDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
BaseDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
BetaFeedbackDialog.tsx Improve link buttons and inline link buttons styling (#8238) 2022-06-29 22:37:34 +00:00
BugReportDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
BulkRedactDialog.tsx Run a minor code quality checker over the repo (#8524) 2022-05-09 22:52:05 +00:00
ChangelogDialog.tsx Auto fix 2021-10-22 17:23:37 -05:00
ConfirmAndWaitRedactDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
ConfirmRedactDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
ConfirmSpaceUserActionDialog.tsx Delete groups (legacy communities system) (#8027) 2022-03-22 23:07:37 +00:00
ConfirmUserActionDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
ConfirmWipeDeviceDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
CreateRoomDialog.tsx Replace MSC3244 support with in-client room version checking (#9018) 2022-07-08 00:32:38 -06:00
CreateSubspaceDialog.tsx Replace MSC3244 support with in-client room version checking (#9018) 2022-07-08 00:32:38 -06:00
CryptoStoreTooNewDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
DeactivateAccountDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
DevtoolsDialog.tsx Move widget screenshots to devtools dialog instead of labs 2022-05-06 13:05:01 -06:00
EndPollDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
ErrorDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
ExportDialog.tsx Run a minor code quality checker over the repo (#8524) 2022-05-09 22:52:05 +00:00
FeedbackDialog.tsx Add additional metadata to feedback submitted through spotlight dialog (#9024) 2022-07-11 12:00:40 +02:00
ForwardDialog.tsx Correct accessibility labels for unread rooms in spotlight (#9003) 2022-07-11 11:34:23 +00:00
GenericFeatureFeedbackDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
HostSignupDialog.tsx Don't unnecessarily persist the host signup dialog (#9043) 2022-07-11 16:50:13 -04:00
HostSignupDialogTypes.ts Use & enforce snake_case naming convention on config.json settings (#8062) 2022-03-18 10:12:36 -06:00
IDialogProps.ts Fix Dialog/Modal types defn 2021-06-07 11:06:30 +01:00
IncomingSasDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
InfoDialog.tsx Step 3.2: Stop using getComponent in code 2022-03-28 14:02:31 -06:00
IntegrationsDisabledDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
IntegrationsImpossibleDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
InteractiveAuthDialog.tsx Automatically log in after registration (#8654) 2022-05-20 19:14:17 +02:00
InviteDialog.tsx Start DM on first message (#8612) 2022-08-04 08:19:52 +02:00
InviteDialogTypes.ts Extract start DM logic to a helper file (#8317) 2022-04-14 16:52:12 +01:00
KeySignatureUploadFailedDialog.tsx Run a minor code quality checker over the repo (#8524) 2022-05-09 22:52:05 +00:00
LazyLoadingDisabledDialog.tsx Auto fix 2021-10-22 17:23:37 -05:00
LazyLoadingResyncDialog.tsx Auto fix 2021-10-22 17:23:37 -05:00
LeaveSpaceDialog.tsx Fix button border color of LeaveSpaceDialog (#8010) 2022-03-10 07:52:09 +00:00
LogoutDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
ManageRestrictedJoinRuleDialog.tsx Fix Manage Restricted Join Rule Dialog for Spaces (#7208) 2021-11-29 09:23:25 +00:00
ManualDeviceKeyVerificationDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
MessageEditHistoryDialog.tsx Apply corrections identified by SonarQube (#8457) 2022-05-03 22:04:37 +01:00
ModalWidgetDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
ModuleUiDialog.tsx Support a module API surface for custom functionality (#8246) 2022-07-05 12:26:44 -06:00
QuestionDialog.tsx Live location share - handle insufficient permissions in location sharing (PSG-610) (#9047) 2022-07-13 10:55:08 +00:00
RegistrationEmailPromptDialog.tsx Remove Countly analytics integration (#7808) 2022-02-15 16:58:30 +00:00
ReportEventDialog.tsx Add an option to ignore (block) a user when reporting their events (#8471) 2022-05-18 16:20:55 +00:00
RoomSettingsDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
RoomUpgradeDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
RoomUpgradeWarningDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
ScrollableBaseModal.tsx Make everything use the KeyBindingManager (#7907) 2022-02-28 16:05:52 +00:00
ServerOfflineDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
ServerPickerDialog.tsx Spike AXE A11Y testing in Cypress (#9111) 2022-08-01 08:31:14 +01:00
SeshatResetDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
SessionRestoreErrorDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
SetEmailDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
ShareDialog.tsx Run a minor code quality checker over the repo (#8524) 2022-05-09 22:52:05 +00:00
SlashCommandHelpDialog.tsx Auto fix 2021-10-22 17:23:37 -05:00
SpacePreferencesDialog.tsx Step 8.5: Move some space settings dialog construction 2022-03-28 14:02:31 -06:00
SpaceSettingsDialog.tsx type Actions (#7862) 2022-02-22 10:04:27 +00:00
StorageEvictedDialog.tsx Remove Piwik support (#8835) 2022-06-14 17:51:51 +01:00
TermsDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
TextInputDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
UntrustedDeviceDialog.tsx Fix look of the untrusted device dialog (#7487) 2022-01-10 10:02:03 +00:00
UploadConfirmDialog.tsx Task - replace img icons with svg components (#8963) 2022-07-06 13:29:26 +02:00
UploadFailureDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
UserSettingsDialog.tsx Device Manager - add new labsed session manager screen (PSG-636) (#9119) 2022-08-08 13:51:00 +00:00
UserTab.ts Device Manager - add new labsed session manager screen (PSG-636) (#9119) 2022-08-08 13:51:00 +00:00
VerificationRequestDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
WidgetCapabilitiesPromptDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00
WidgetOpenIDPermissionsDialog.tsx Step 1: Remove all usage of @replaceableComponent 2022-03-28 14:02:31 -06:00