Previously it made some complicated assumptions about the contexts it was called in (it generally assumed it just had to shuffle rooms between tags and didn't really handle new rooms very well). The algorithm now eagerly tries to drop rooms from tags and carefully inserts them. The actual insertion logic is mostly untouched: the only part changed is how it handles failure to insert into tag. It shouldn't be possible for this algorithm to completely skip a room unless the tag is empty, so we special case that. There are several TODO comments to be addressed here. Namely, it doesn't handle manually ordered tags (favourites, custom, etc) and doesn't check if tags are even enabled. Changes in this area are waiting for https://github.com/matrix-org/matrix-react-sdk/pull/2686 to land to take advantage of monitoring the settings flag for tags. |
||
---|---|---|
.. | ||
ActiveWidgetStore.js | ||
CustomRoomTagStore.js | ||
FlairStore.js | ||
GroupStore.js | ||
LifecycleStore.js | ||
MessageComposerStore.js | ||
RoomListStore.js | ||
RoomScrollStateStore.js | ||
RoomViewStore.js | ||
SessionStore.js | ||
TagOrderStore.js | ||
WidgetEchoStore.js |