Michael Telatynski
da7aa4055e
Conform more of the code base to strict null checking ( #10147 )
...
* Conform more of the code base to strict null checking
* More strict fixes
* More strict work
* Fix missing optional type
* Iterate
2023-02-13 17:01:43 +00:00
Michael Telatynski
61a63e47f4
Comply with noImplicitAny ( #9940 )
...
* Stash noImplicitAny work
* Stash
* Fix imports
* Iterate
* Fix tests
* Delint
* Fix tests
2023-02-13 11:39:16 +00:00
Michael Telatynski
030b7e90bf
Enable @typescript-eslint/explicit-function-return-type in /src ( #9788 )
...
* Enable `@typescript-eslint/explicit-member-accessibility` on /src
* Prettier
* Enable `@typescript-eslint/explicit-function-return-type` in /src
* Fix types
* tsc strict fixes
* Delint
* Fix test
* Fix bad merge
2023-01-12 13:25:14 +00:00
Michael Telatynski
f1e8e7f140
Enable @typescript-eslint/explicit-member-accessibility on /src ( #9785 )
...
* Enable `@typescript-eslint/explicit-member-accessibility` on /src
* Prettier
2022-12-16 12:29:59 +00:00
Michael Weimann
526645c791
Apply prettier formatting
2022-12-12 12:24:14 +01:00
Eric Eastwood
2393510a7f
Fix getRelationsForEvent under TypeScript strict mode ( #9558 )
...
* Fix getRelationsForEvent tsc strictness
* Use shared type for GetRelationsForEvent
* Fix lint
* Add alternative type
* getRelationsForEvent is not required
* Relations are optional
* Reactions are optional
* We expect relations in these tests
* Add more protection if the eventID is not defined
* Allow null too
* Better test typing
* User ID is not necessary unless something is selected
* It's okay to [].includes(null)
* Null is as good as undefined here
* Null or undefined is good here
* We have some expectations for the tests
* The room and user can be undefined too
* Protec
* Reactions are optional
* Try match signatures
* Null or undefined
* More null or undefined
* Protec
* Fix typo (wrong variable)
* Remove optional params
See https://github.com/matrix-org/matrix-react-sdk/pull/9558#discussion_r1017515913
* Fix up last maaaaybe relevant lint
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-11-21 20:54:24 -07:00
Šimon Brandner
9b8b1d193e
Disable redacting reactions if we don't have sufficient permissions ( #8767 )
2022-06-10 18:41:05 +00:00
Michael Telatynski
007b8816df
Tweak ReactionsRow to make saner use of its RoomContext ( #8623 )
...
* Tweak ReactionsRow to make saner use of its RoomContext
* `this.context.canReact` already asserts membership=join
2022-05-17 14:17:27 +01:00
Travis Ralston
997d6d40bf
Step 1: Remove all usage of @replaceableComponent
2022-03-28 14:02:31 -06:00
Michael Telatynski
7fa01ffb06
Improve typing around event emitter handlers ( #7816 )
2022-02-22 12:18:08 +00:00
Kerry
fed53a268b
A11y - fix anchors-as-buttons ( #7444 )
...
* add link_inline accessiblebutton variant
* valid anchors in SecurityRoomSettingsTab
Signed-off-by: Kerry Archibald <kerrya@element.io>
* new room intro link button
Signed-off-by: Kerry Archibald <kerrya@element.io>
* replace anchor with button in rerequest encryption keys message
Signed-off-by: Kerry Archibald <kerrya@element.io>
* inline button in UrlPreviewSettings
Signed-off-by: Kerry Archibald <kerrya@element.io>
* ButtonResetDefault mixin
Signed-off-by: Kerry Archibald <kerrya@element.io>
* inline link buttons in TextForEvent
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix anchors in InviteDialog
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix anchors in DevToolsDialog
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix anchors in login/registration/reset pword flows
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix types after fixing anchors in devtools
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix anchors in MemberEventListSummary
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix anchors in ReactionsRow and RoomUpgrade
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix anchors in ReplyChain
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix more anchors
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix anchors in auth comps
* stylelint fixes
Signed-off-by: Kerry Archibald <kerrya@element.io>
* remove ignore of jsx-a11y rule that is not added yet
Signed-off-by: Kerry Archibald <kerrya@element.io>
* devtools style important explainer
Signed-off-by: Kerry Archibald <kerrya@element.io>
* translate button alt in devtools dialog
Signed-off-by: Kerry Archibald <kerrya@element.io>
* AccessibleButton is reactionsrow
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix viewsourcevent button placement, use AccessibleButton
Signed-off-by: Kerry Archibald <kerrya@element.io>
* use AccessibleButton in EventTile
Signed-off-by: Kerry Archibald <kerrya@element.io>
* unignore jsx-a11y/anchor-is-valid
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix lint issue in test jsx
Signed-off-by: Kerry Archibald <kerrya@element.io>
* update coment
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-01-07 10:40:53 +01:00
Michael Telatynski
097c40b577
Disable quick reactions button when no permissions ( #7412 )
2021-12-23 12:01:40 +00:00
Michael Telatynski
fe24c8ad2a
Improve ThreadPanel ctx menu accessibility ( #7217 )
2021-11-29 17:42:53 +00:00
Michael Telatynski
ce78cdf4ad
Conform to new react and typescript eslint rules
2021-07-19 22:43:11 +01:00
J. Ryan Stinnett
ae0a8b8da4
Auto-fix lint errors
2021-06-29 13:11:58 +01:00
J. Ryan Stinnett
7d59d5cb39
Tune types in ReactionsRow
2021-05-26 16:51:26 +01:00
J. Ryan Stinnett
d4ca1babbe
Update reactions row on event decryption
...
This fixes a race (perhaps revealed by the recent lazy decryption work) where
the reactions row have reactions to show, but the event would not be decrypted,
so they wouldn't render. Adding a decryption listener gets things moving again.
Fixes https://github.com/vector-im/element-web/issues/17461
2021-05-26 16:47:21 +01:00
Michael Telatynski
dab75f9b88
Fix add reaction prompt showing even when user is not joined to room
2021-05-20 12:20:53 +01:00
Michael Telatynski
6e5847ea6b
Fix right clicking on add reactions prompt button behaviour
2021-05-17 10:01:56 +01:00
Michael Telatynski
a22a1918e1
Fix add reactions prompt button showing up even if all reactions have been removed
2021-05-17 10:01:43 +01:00
Michael Telatynski
76afc1100a
Convert to Typescript and move from ClientPeg to Context
2021-05-13 14:13:00 +01:00
