Richard Lewis
df438924a7
Remove logging.
2017-12-07 09:57:53 +00:00
Luke Barnard
4603d593de
Merge pull request #1588 from pvagner/develop
...
Add some missing translatable strings
2017-12-07 09:41:39 +00:00
Peter Vágner
839f938c91
Argh! Reworked AccessibleButton key handling again. It turned out by
...
fixing behaviour when pressing the enter key breaks behaviour when
pressing space to activate the buttons. So we are now handling enter
onKeyDown and space onKeyUp. Also briefly explained the situation with
comments.
2017-12-07 10:20:27 +01:00
Peter Vágner
4171675221
Add some comments explaining how we are using aria-hidden property to
...
hide content outside of the BaseDialog to screen reader users.
2017-12-07 09:44:00 +01:00
Richard Lewis
ed675fe791
Allow bypass of widget loading screen on hide / show.
2017-12-06 22:54:32 +00:00
David Baker
2a01985076
better proptypes
2017-12-06 19:07:12 +00:00
David Baker
0deed4bb88
null guard
2017-12-06 19:05:25 +00:00
David Baker
1a3671d241
remove stray param
2017-12-06 19:04:29 +00:00
David Baker
5bca5a7a8e
More underscore
2017-12-06 19:02:26 +00:00
David Baker
aa99b898ce
Add that it might not work now either
...
also a comma
2017-12-06 18:57:48 +00:00
Luke Barnard
65d88334a9
Fix linting
...
React DnD specifies functions with upper-case first letters
2017-12-06 16:48:18 +00:00
Richard Lewis
e20db416f2
Add field to bypass riot widget loading screen.
2017-12-06 16:44:41 +00:00
David Baker
4462694438
lint
2017-12-06 16:06:33 +00:00
David Baker
65c210cdde
Warn when migrating e2e data to indexeddb
2017-12-06 15:28:20 +00:00
Luke Barnard
7e1f1cdbd9
Move DragDropContext to wrap LoggedInView
...
Becuase the tests rely on being able to inspect the state of MatrixChat
2017-12-06 15:01:16 +00:00
Luke Barnard
35a108eecc
Simplify render of TagPanel - remove sorting
2017-12-06 14:17:26 +00:00
Luke Barnard
7aa5dcef69
Move DragDropContext to wrap entire app
2017-12-06 13:10:58 +00:00
Luke Barnard
a8a650c24a
Move TagTile to separate file, and make it dragable
2017-12-06 11:25:46 +00:00
Peter Vágner
f9b0243c8e
Merge branch 'develop' into dialog-a11y
2017-12-06 11:10:18 +01:00
Peter Vágner
802abe7091
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk into develop
2017-12-06 11:07:01 +01:00
Peter Vágner
60ada30680
Forgot to turn div displaying error text into an aria-alert in the
...
create group dialog.
2017-12-05 23:46:02 +01:00
Peter Vágner
eda453bbe5
Fixed an issue where pressing enter key to activate the AccessibleButton
...
was also activating normal button that might just have received the
system focus as a result of the key press and the other way round.
The most obvious occurence of this issue is that dialogs were
reappearing when dismissed by pressing the enter key.
2017-12-05 23:23:40 +01:00
Richard Lewis
3206527d73
Remove logging.
2017-12-05 21:59:44 +00:00
Richard Lewis
7f86ed35a3
Only show custom title if different from app name.
2017-12-05 21:49:11 +00:00
Richard Lewis
1415a83a61
Merge branch 'rxl881/titleBar' of https://github.com/matrix-org/matrix-react-sdk into rxl881/customTitle
2017-12-05 21:42:47 +00:00
Richard Lewis
d5d5397959
Set custom widget title.
2017-12-05 21:41:44 +00:00
Richard Lewis
9fd8deb16d
Add maximize / minimize apps drawer icons.
2017-12-05 18:18:51 +00:00
Luke Barnard
8178496457
Implement Store for ordering tags in the tag panel
2017-12-05 14:45:44 +00:00
Peter Vágner
a31af39ca8
Applied aria-describedby to all other dialogs that are using BaseDialog.
...
Also added initial focus where it has not been set.
2017-12-05 13:52:20 +01:00
Richard Lewis
9eb334a1d4
Merge pull request #1640 from matrix-org/rxl881/widgetTitle
...
Add widget -> riot postMessage API
2017-12-05 12:02:57 +00:00
Luke Barnard
aac5bcfe80
Attempt to improve TagPanel performance
...
by only recalculating rooms to show (for a given group) when a group updates.
2017-12-05 11:25:30 +00:00
Peter Vágner
4f83f6cf25
Move keyboard focus management back to the BaseDialog rather than
...
leaving it in the Modal manager.
We are using Modal manager to load other components not just BaseDialog
and its subclasses and they might require different keyboard handling.
Also depend on focus-trap-react rather than react-focus-trap for locking
keyboard focus inside the dialog. The experience is much nicer and even
the FocusTrap element it-self no longer gains the focus.
On a side note using the FocusTrap element outside the dialog (on
its parent) stops it from working properly.
2017-12-05 08:50:40 +01:00
Richard Lewis
49a2985515
Register message endpoints.
...
Store endpoint origins only.
2017-12-05 00:08:17 +00:00
Peter Vágner
5ccbcf02e2
Several changes improving accessibility of the dialogs
...
- Wrapped all the modals inside a react-focus-trap component disabling
keyboard navigation outside the modal dialogs
- Disabled our custom key handling at dialog level. Cancelling on esc
key is now handled via FocusTrap component.
- Removed onEnter prop from the BaseDialog component. Dialogs that
submit data all now embed a form with onSubmit handler. And since
keyboard focus is now managed better via FocusTrap it no longer makes
sense for the other dialog types. Fixes
https://github.com/vector-im/riot-web/issues/5736
- Set aria-hidden on the matrixChat outer node when showing dialogs to
disable navigating outside the modals by using screen reader specific
features.
2017-12-03 21:38:21 +01:00
Richard Lewis
c9b8aab0e0
Workings for future posterity - Can't access iframe content from parent. iframe needs to initiate. Postmessage data up the stack.
2017-12-03 19:44:59 +00:00
Richard Lewis
3a89b90e57
Add stub handler for image snapshot
2017-12-03 11:25:15 +00:00
Luke Barnard
641add4964
Fix one kind of scroll jump
...
by calling onWidgetLoad when the <img> in MImageBody loads
2017-12-01 14:18:13 +00:00
Luke Barnard
b26cf23574
Merge pull request #1641 from matrix-org/luke/tag-panel-shift-click-semantics
...
Implement shift-click and ctrl-click semantics for TP
2017-12-01 12:04:21 +00:00
Luke Barnard
363fe04a10
isCtrlOrCmdKeyEvent -> isOnlyCtrlOrCmdKeyEvent
2017-12-01 10:44:00 +00:00
Luke Barnard
ddd0e161c0
Fix broken imports
2017-12-01 10:41:56 +00:00
Luke Barnard
fe81fcb8c6
Factor out isCtrlOrCmdKeyEvent, use that in TagPanel
...
as opposed to the incorrect ctrl || meta
2017-12-01 10:30:49 +00:00
Luke Barnard
eaaa9fe747
Don't show group when clicking tag panel
2017-11-30 15:35:40 +00:00
Richard Lewis
5ff5ca4705
Remove logging and broken title fetching functions.
2017-11-30 14:50:30 +00:00
Luke Barnard
3bcb3195c4
Implement shift-click and ctrl-click semantics for TP
2017-11-30 14:48:54 +00:00
Richard Lewis
2cfbbb000e
Refactor messaging listerners.
2017-11-30 10:20:29 +00:00
Stefan Parviainen
437a440bdf
Add missing id
...
Signed-off-by: Stefan Parviainen <pafcu@iki.fi>
2017-11-30 08:32:18 +01:00
Richard Lewis
4f5f44ff38
Add widget postmessage API stub.
2017-11-29 22:16:22 +00:00
Stefan Parviainen
cb5c9f2c5a
Make Dialogs more accessible
...
Signed-off-by: Stefan Parviainen <pafcu@iki.fi>
2017-11-29 21:13:48 +01:00
Luke Barnard
f708250d44
Add feature flag for Tag Panel
2017-11-29 18:00:42 +00:00
Luke Barnard
ead30fae9d
Use unmounted instead of mounted
2017-11-29 17:07:43 +00:00