Michael Telatynski
4574c665ea
Conform more code to strict null checking ( #10167 )
...
* Conform more code to strict null checking
* Delint
* Iterate PR based on feedback
2023-02-16 17:21:44 +00:00
Michael Telatynski
61a63e47f4
Comply with noImplicitAny ( #9940 )
...
* Stash noImplicitAny work
* Stash
* Fix imports
* Iterate
* Fix tests
* Delint
* Fix tests
2023-02-13 11:39:16 +00:00
Michael Telatynski
030b7e90bf
Enable @typescript-eslint/explicit-function-return-type
in /src ( #9788 )
...
* Enable `@typescript-eslint/explicit-member-accessibility` on /src
* Prettier
* Enable `@typescript-eslint/explicit-function-return-type` in /src
* Fix types
* tsc strict fixes
* Delint
* Fix test
* Fix bad merge
2023-01-12 13:25:14 +00:00
Michael Telatynski
f1e8e7f140
Enable @typescript-eslint/explicit-member-accessibility
on /src ( #9785 )
...
* Enable `@typescript-eslint/explicit-member-accessibility` on /src
* Prettier
2022-12-16 12:29:59 +00:00
Michael Weimann
526645c791
Apply prettier formatting
2022-12-12 12:24:14 +01:00
Michael Weimann
436146105e
Implement voice broadcast device selection ( #9572 )
2022-11-15 10:02:40 +01:00
Michael Telatynski
da779531f1
Close context menu when a modal is opened to prevent user getting stuck ( #9560 )
2022-11-09 15:33:09 +00:00
Michael Telatynski
3747464b41
Make SonarCloud happier ( #9545 )
...
* Make SonarCloud happier
* i18n
* Iterate
* Update AddExistingToSpaceDialog.tsx
* Update SlashCommands.tsx
2022-11-07 13:45:34 +00:00
Michael Telatynski
13db1b17be
Prevent useContextMenu isOpen from being true if the button ref goes away ( #9418 )
2022-10-17 17:42:04 +01:00
Kerry
776ffa4764
Device manager - current session context menu ( #9386 )
...
* add destructive option and close on interaction options
* add kebab context menu wrapper
* use kebab context menu in current device section
* use named export
* lint
* sessionman tests
2022-10-13 09:07:34 +02:00
Michael Weimann
41960b164b
Fix unknonw div props in context menu ( #9277 )
2022-09-14 14:05:38 +02:00
Šimon Brandner
3eecd68175
Fix context menu being opened when clicking message action bar buttons ( #9200 )
2022-08-18 09:18:18 +02:00
Šimon Brandner
19e514d83c
Remove dead code ( #9035 )
2022-07-11 07:52:44 +02:00
Michael Telatynski
964c60d086
Apply corrections identified by SonarQube ( #8457 )
2022-05-03 22:04:37 +01:00
Janne Mareike Koschinski
ee2ee3c08c
Implement new Read Receipt design ( #8389 )
...
* feat: introduce new alignment types for tooltip
* feat: introduce new hook for tooltips
* feat: allow using onFocus callback for RovingAccessibleButton
* feat: allow using custom class for ContextMenu
* feat: allow setting tab index for avatar
* refactor: move read receipts out of event tile
* feat: implement new read receipt design
* feat: update SentReceipt to match new read receipts as well
2022-04-22 17:09:44 +02:00
Šimon Brandner
7c41b8612d
Put the right-click message context menu to the right ( #8339 )
...
* Improve `alwaysAboveRightOf()` typing
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Improve typing of `alwaysAboveLeftOf()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add `aboveRightOf()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Use `aboveRightOf()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix typo
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-04-17 09:50:13 -04:00
Šimon Brandner
d162e021e1
Add message right click context menu v2 ( #5672 )
...
* migrate the message context menu to IconizedContextMenu
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* migrate the message context menu to IconizedContextMenu
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* Added right-click menu
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* add message context menu group keys
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* add message context menu icons
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* add _MessageContextMenu.scss license header
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* use null vars for context menu lists
* Add allowOverridingNativeContextMenus()
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Use allowOverridingNativeContextMenus()
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove mistaken line
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix styling
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* InputHTMLAttributes -> AllHTMLAttributes
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Convert to TS
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add some types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Make onClick optional
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add rightClick prop
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add copy button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* What about upgrading deps after the eslint migration, Simon?
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add edit button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* fix
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add reply button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add react button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Cleanup render()
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix comments
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add save button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Don't show context menu if editing
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add special handling for click a timestamp
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix double empty line
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Don't show context menu for images
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Cleanup
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix order
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Keep action bar shown when right-clicking
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Highlight event tile when right-clicking
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Delint
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Pointless change so that I can re-run the CI
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove dowload button
Because we don't use this menu when clicking on images
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Be more clear for non-bools
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Use triggerOnMouse down prop
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove a comment
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove unused var
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove unnecessary import
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add some missing types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add missing type
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove unused import
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add a missing type
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix types/naming
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add missing current
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove unused var
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix editing and replying
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* i18n
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix import
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Support right-click context menu for threads
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Make button order match `MessageActionBar`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix missing permalink button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove useless part of if statement
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Some small refactoring for consistency
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Some more refactoring
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix `editEvent()` call
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Make editing polls work
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix collapse reply chain button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix timelineRenderingType
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix reply button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Hide right-click context menu behind a labs flag
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add missing return type
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Make `contextMene` optional
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Move `renderContextMenu()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Simplify `renderContextMenu()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Improve `aboveLeftOf` typing
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Use `InputHTMLAttributes`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Disable message right-click context menu in browser (for now)
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Give permalink button more props
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Co-authored-by: Michael Weimann <mail@michael-weimann.eu>
2022-04-15 08:22:59 -06:00
Travis Ralston
997d6d40bf
Step 1: Remove all usage of @replaceableComponent
2022-03-28 14:02:31 -06:00
Michael Telatynski
115e17b097
Fix positioning of the thread context menu ( #7918 )
2022-03-01 08:32:29 +00:00
Šimon Brandner
df591ee835
Make everything use the KeyBindingManager
( #7907 )
2022-02-28 16:05:52 +00:00
Robin
ece2b8572a
Fix edge case in context menu chevron positioning ( #7899 )
...
* Fix edge case in context menu chevron positioning
Signed-off-by: Robin Townsend <robin@robin.town>
* Expand context menu positioning regression tests
Signed-off-by: Robin Townsend <robin@robin.town>
2022-02-25 17:49:57 +00:00
Robin
85dc58a504
Try harder to keep context menus inside the window ( #7863 )
...
* Try harder to keep context menus inside the window
Signed-off-by: Robin Townsend <robin@robin.town>
* Use UIStore for window dimensions
Signed-off-by: Robin Townsend <robin@robin.town>
* Test ContextMenu positioning
Signed-off-by: Robin Townsend <robin@robin.town>
2022-02-24 10:25:27 -05:00
Michael Telatynski
991257cbc3
Fix accessibility and consistency of MessageComposerButtons ( #7679 )
2022-01-31 16:05:05 +00:00
Michael Telatynski
f3776f8944
Prevent keyboard propagation out of context menus ( #7437 )
2021-12-22 10:53:17 +00:00
Eric Eastwood
9289c0c90f
Refactor ContextMenu
to use RovingTabIndex
(more consistent keyboard navigation accessibility) ( #7353 )
...
Split off from https://github.com/matrix-org/matrix-react-sdk/pull/7339
2021-12-17 11:08:56 -06:00
Michael Telatynski
132e19beb7
Update typescript-eslint plugin & parser ( #7351 )
2021-12-13 23:39:45 +00:00
Michael Telatynski
2e4fe7891a
Fix input field behaviour inside context menus ( #7293 )
2021-12-07 09:36:28 +00:00
Michael Telatynski
fe24c8ad2a
Improve ThreadPanel ctx menu accessibility ( #7217 )
2021-11-29 17:42:53 +00:00
Germain
0bae79d3c3
Improve Thread View UI ( #7063 )
2021-11-02 13:18:51 +00:00
Michael Telatynski
04c06b6aa8
Improve RovingTabIndex & Room List filtering performance ( #6987 )
2021-10-26 12:16:50 +01:00
Michael Telatynski
1c8bcce0ed
comment
2021-10-07 11:13:13 +01:00
Michael Telatynski
047f182cd8
focusLock only specific context menus
2021-10-07 11:04:10 +01:00
Michael Telatynski
b373b98d48
Simplify aria menu item roles/selectors
2021-10-06 16:49:53 +01:00
Michael Telatynski
a6c780674a
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into t3chguy/a11y/focus-lock-ctx-menu
...
Conflicts:
src/components/views/spaces/SpaceCreateMenu.tsx
2021-10-06 16:39:52 +01:00
Michael Telatynski
898e4acb4f
Don't let click events propagate out of context menus
2021-10-01 10:00:53 +01:00
Dariusz Niemczyk
0cfa2a58c7
Add ability to expand and collapse long quoted messages ( #6701 )
...
In case where we had a very long message the experience of going between
messages to see the full quote isn't very nice on desktop, therefore this commit
adds a button with additional hotkey to normalize the experience a bit.
Fixes https://github.com/vector-im/element-web/issues/18884
2021-09-27 12:20:37 +02:00
Dariusz Niemczyk
60174c9836
Add a better comment describing the behavior
2021-09-14 14:51:17 +02:00
Dariusz Niemczyk
ceafa83392
Fix invalid ContextualMenu positions
2021-09-13 22:11:58 +02:00
Dariusz Niemczyk
e913f03a67
Add missing types
2021-09-13 22:11:43 +02:00
Michael Telatynski
42d6afd4b1
Merge pull request #6497 from matrix-org/t3chguy/fix/18093
2021-07-30 12:25:44 +01:00
Andrew Morgan
a7c15b2ac0
Fix DialPad and Call Menu buttons not working when a call is fullscreened. ( #6496 )
...
This PR:
* Moves the dialpad and hold/transfer menu buttons into the part of the DOM that's included when a call is fullscreen'd.
* Tweaks `ContextMenu` to allow menu content to be mount as a child of the current component, rather than at the root of the DOM (which was not included in the full-screen'd content).
<!-- Please read https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md before submitting your pull request -->
<!-- Include a Sign-Off as described in https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md#sign-off -->
`Signed-off-by: Andrew Morgan <andrewm@element.io>`
2021-07-29 17:51:27 +01:00
Michael Telatynski
67ef263940
Refactor SpaceButton to be more reusable and add context menu to Home button
2021-07-28 17:40:33 +01:00
Michael Telatynski
171874ae30
Use FocusLock around ContextMenus to simplify focus management
2021-07-02 16:31:37 +01:00
J. Ryan Stinnett
ae0a8b8da4
Auto-fix lint errors
2021-06-29 13:11:58 +01:00
Germain Souquet
f156c2db15
prevent reflow in app when accessing window dimensions
2021-05-25 10:28:43 +01:00
Michael Telatynski
d0458332d5
fix roving tab index intercepting home/end in space create menu
2021-05-14 11:22:20 +01:00
Travis Ralston
c230a75eda
Flag structural components as replaceable
2021-03-08 20:23:24 -07:00
Michael Telatynski
483d56320c
Beginning of space creation UX from space panel
2021-03-01 17:47:40 +00:00
J. Ryan Stinnett
72ff919512
Merge pull request #5644 from weeman1337/fix-contextmenu-padding
...
Fix context menu leaving visible area
2021-02-22 17:42:09 +00:00
Michael Telatynski
354925c2c8
Improve TS definitions
2021-02-18 15:16:07 +00:00