Michael Telatynski
65e27cd6be
If pasting a url atop another url, don't wrap one in the other ( #8642 )
2022-05-18 10:08:24 +01:00
Michael Telatynski
5976f59827
Add missing return values in Read Receipt animation code ( #8625 )
2022-05-17 15:08:23 +01:00
Travis Ralston
afaeaaf954
Convert setupNotificationListener
to an unbound function ( #8618 )
...
This isn't called by an event handler directly, so shouldn't need to be bound. Equally, this shouldn't cause any problems.
This is a long-shot attempt at completing https://github.com/vector-im/element-web/issues/22141
2022-05-17 00:21:29 -06:00
Šimon Brandner
e1d11db256
Don't show public indicator on spaces ( #8607 )
2022-05-16 10:24:01 +02:00
Travis Ralston
bc0bfa6377
Iterate on search results for message bubbles ( #7047 )
...
* PSFD-455: Iterate on search results for message bubbles
Though not perfect, this is a bit better than it was before. Specifically, we ensure our matching for `isOwnEvent` correctly identifies the user and that the results don't look *awful*.
There's still room for improvement, but this should be a measurable improvement itself. Most notably, this doesn't fix a couple obvious bugs due to complexity:
* Message bubbles have the wrong corners for the display format (pre-existing).
* The sender's own messages are missing avatars/names. This is just way too complex to fix.
**Requires https://github.com/matrix-org/matrix-js-sdk/pull/2004 **
* Tweak opacity
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-13 15:20:43 +00:00
Michael Telatynski
438e66bb3f
Show full thread message in hover title on thread summary ( #8568 )
2022-05-13 14:32:28 +01:00
Robin
26bc3ab0aa
Tweak video rooms copy ( #8582 )
...
* "Video room" → "New video room"
* "Connect now" → "Join"
* "N people connected" → "N people joined"
* "Connected" → "Joined"
* Fix tests
2022-05-13 12:45:38 +00:00
Germain
fdd5494402
Add dialog to navigate long room topics ( #8517 )
2022-05-13 08:55:10 +01:00
Michael Weimann
7ed3089434
Improve tooltip positioning
...
Signed-off-by: Michael Weimann <michaelw@matrix.org>
2022-05-12 14:05:55 +02:00
Suguru Hirahara
0951a766aa
Fix displaying hidden events on threads ( #8555 )
...
* Fix avatar size and style inheritances for hidden events in the thread view
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use a variable
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* yarn run lint:style --fix
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Reset the comment
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Re-add padding-left override for bubble layout
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* yarn run lint:style --fix
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add a empty line
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Adjust avatar and E2E icon position inside .mx_EventTile_info
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Update src/components/views/rooms/EventTile.tsx
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* Align with mx_EventTile_line
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Align mx_EventTile_line and avatar + E2E icon
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-12 08:04:54 +01:00
Michael Telatynski
36f2824eb8
Update thread summary when latest event gets decrypted ( #8564 )
2022-05-11 17:32:48 +01:00
Eric Eastwood
3a241e0dfb
Log TimelinePanel
debugging info when opening the bug report modal ( #8502 )
...
To debug all of the timeline problems:
- https://github.com/vector-im/element-web/issues/21613
- https://github.com/vector-im/element-web/issues/21922
- https://github.com/vector-im/element-web/issues/21432
- https://github.com/vector-im/element-web/issues/21533
2022-05-09 21:32:25 -05:00
Travis Ralston
401e124df6
Merge branch 'develop' into 19245-improve-styling-of-search-initialization-errors
2022-05-09 19:32:43 -06:00
Travis Ralston
548290b006
Run a minor code quality checker over the repo ( #8524 )
...
* Run a minor code quality checker over the repo
Largely targeted at spelling of common words and misc code issues.
* Update snapshots
2022-05-09 22:52:05 +00:00
Michael Telatynski
674aec4050
Fix regression around pasting links ( #8537 )
...
* Fix regression around pasting links
* Add tests
2022-05-09 12:39:32 +00:00
Kalle Struik
7c07ad155c
Improve the styling of search initialization errors.
...
Signed-off-by: Kalle Struik <kalle@kallestruik.nl>
2022-05-09 11:20:36 +02:00
Šimon Brandner
b1daf3fec2
Add a Copy link
button to the right-click message context-menu labs feature ( #8527 )
...
* Simplify `Share` button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add proper `Copy link` button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* i18n
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-05-09 08:25:14 +02:00
Sinharitik589
dfc7224fc7
Converting selected text to MD link when pasting a URL ( #8242 )
...
* Converting selected text to MD link when pasting a URL
* Update src/editor/operations.ts
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* Converting selected text to MD link when pasting a URL
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-09 06:34:56 +01:00
Michael Weimann
7e63202f9a
Replace compose context menu with IconizedContextMenu ( #22046 )
...
Signed-off-by: Michael Weimann <michaelw@matrix.org>
2022-05-07 20:19:08 +02:00
Travis Ralston
d39d332f54
Merge pull request #8521 from matrix-org/travis/remove-unused-labs-1
...
Remove some labs features which don't get used or create maintenance burden: custom status, multiple integration managers, and do not disturb
2022-05-06 13:21:07 -06:00
Travis Ralston
2aec197354
Remove feature_many_integration_managers
...
Rationale: If we want this feature, design will do it properly.
2022-05-06 12:46:26 -06:00
Travis Ralston
aa664b88a4
Remove feature_custom_status
...
Rationale: It's legacy and wrong in so many ways.
2022-05-06 12:39:03 -06:00
Suguru Hirahara
cce0833c21
Simplify ReplyPreview implementation ( #8516 )
...
- Use AccessibleButton for cancel button, following other cases on UI
- Use flexbox for RTL layout to remove clear: both
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-06 18:06:32 +00:00
Šimon Brandner
b12c002602
Order receipts with the most recent on the right ( #8506 )
2022-05-05 12:10:48 +00:00
Robin
658ff4dfe6
Iterate video room designs in labs ( #8499 )
...
* Remove blank header from video room view frame
* Add video room option to space context menu
* Remove duplicate tooltips from face piles
* Factor RoomInfoLine out of SpaceRoomView
* Factor RoomPreviewCard out of SpaceRoomView
* Adapt RoomPreviewCard for video rooms
* "New video room" → "Video room"
* Add comment about unused cases in RoomPreviewCard
* Make widgets in video rooms mutable again to de-risk future upgrades
* Ensure that the video channel exists when mounting VideoRoomView
2022-05-04 17:02:06 -04:00
Michael Telatynski
d79349029a
Fix soft crash around threads when room isn't yet in store ( #8496 )
2022-05-04 16:39:36 +01:00
Michael Telatynski
964c60d086
Apply corrections identified by SonarQube ( #8457 )
2022-05-03 22:04:37 +01:00
Michael Telatynski
f29ef04751
Fix race conditions around threads ( #8448 )
2022-05-03 14:25:08 +01:00
Janne Mareike Koschinski
3e31fdb6a7
read receipts: improve tooltips to show names of users ( #8438 )
2022-05-02 11:46:11 +02:00
Emmanuel
d294dad04d
fix timeline search with empty text box should do nothing ( #8262 )
...
* fix timeline search with empty text box should do nothing
* test SearchBar component
* fix lint error
* Update SearchBar-test.tsx
Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-05-02 01:09:59 +00:00
Suguru Hirahara
12e8534c2b
Implement improved spacing for the thread list and timeline ( #8337 )
...
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-04-29 11:03:39 +00:00
Michael Telatynski
fddbc429a9
Fix issue with thread notification state ignoring initial events ( #8417 )
2022-04-29 09:48:57 +01:00
Michael Telatynski
8baa46b0dd
Fix baseline misalignment of thread panel summary by deduplication ( #8413 )
2022-04-27 18:10:27 +01:00
Janne Mareike Koschinski
5a5a792593
Read Receipts: never show +1, if it’s just 4, show all of them ( #8428 )
...
* read receipts: never show +1, if it’s just 4, show all of them
* read receipts: improve type signature for determineAvatarPosition
2022-04-27 14:27:29 +02:00
Janne Mareike Koschinski
e718242912
Read Receipts "Fall from the Sky" ( #8414 )
...
* fix: don't pass hideTitle to base avatar
* fix: correctly position read receipt markers
2022-04-26 18:09:41 +02:00
Janne Mareike Koschinski
9b0ab3321c
Add opt-in analytics to onboarding tasks ( #8409 )
...
* Add interaction tracking to explore room, send DM and create room events in onboarding view and elsewhere
* Update matrix analytics events dependency
2022-04-26 13:31:53 +02:00
Janne Mareike Koschinski
e7c91397f1
Make read receipts handle nullable roomMembers correctly ( #8410 )
...
* make readReceipt roomMember nullable, as it should be
* add fallback click interaction for read receipts of unknown users
2022-04-26 12:35:05 +02:00
Michael Telatynski
b2bebda670
Tweak ReadReceiptGroup to better handle disambiguation ( #8402 )
2022-04-25 11:04:55 +00:00
Janne Mareike Koschinski
ee2ee3c08c
Implement new Read Receipt design ( #8389 )
...
* feat: introduce new alignment types for tooltip
* feat: introduce new hook for tooltips
* feat: allow using onFocus callback for RovingAccessibleButton
* feat: allow using custom class for ContextMenu
* feat: allow setting tab index for avatar
* refactor: move read receipts out of event tile
* feat: implement new read receipt design
* feat: update SentReceipt to match new read receipts as well
2022-04-22 17:09:44 +02:00
Michael Telatynski
86419b1925
Fix regression around the room list treeview keyboard a11y ( #8385 )
2022-04-21 17:21:44 +01:00
Robin
c83ad1faa7
Add local echo of connected devices in video rooms ( #8368 )
2022-04-21 07:41:38 -04:00
Robin
6e86a14cc9
Show a lobby screen in video rooms ( #8287 )
...
* Show a lobby screen in video rooms
* Add connecting state
* Test VideoRoomView
* Test VideoLobby
* Get the local video stream with useAsyncMemo
* Clean up code review nits
* Explicitly state what !important is overriding
* Use spacing variables
* Wait for video channel messaging
* Update join button copy
* Show frame on both the lobby and widget
* Force dark theme for video lobby
* Wait for the widget to be ready
* Make VideoChannelStore constructor private
* Allow video lobby to shrink
* Add invite button to video room header
* Show connected members on lobby screen
* Make avatars in video lobby clickable
* Increase video channel store timeout
* Fix Jitsi Meet getting wedged on startup in Chrome and Safari
* Revert "Fix Jitsi Meet getting wedged on startup in Chrome and Safari"
This reverts commit 9f77b8c227c1a5bffa5d91b0c48bf3bbc44d4cec.
* Disable device buttons while connecting
* Factor RoomFacePile into a separate file
* Fix i18n lint
* Fix switching video channels while connected
* Properly limit number of connected members in face pile
* Fix CSS lint
2022-04-20 11:03:33 -04:00
Janne Mareike Koschinski
bca9caa98e
Settings toggle to disable Composer Markdown ( #8358 )
2022-04-19 14:53:59 +01:00
Šimon Brandner
511965b840
Cleanup MessageContextMenu
code ( #8351 )
2022-04-19 07:59:23 +00:00
Šimon Brandner
7c41b8612d
Put the right-click message context menu to the right ( #8339 )
...
* Improve `alwaysAboveRightOf()` typing
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Improve typing of `alwaysAboveLeftOf()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add `aboveRightOf()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Use `aboveRightOf()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix typo
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-04-17 09:50:13 -04:00
Šimon Brandner
11e0a3a8fa
Enable the message right-click context menu in the browser ( #8336 )
...
* Enable the message right-click context menu in the browser
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Move `getSelectedText()` to `strings.ts`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Move `canCancel()` to `EventUtils.ts`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-04-15 12:12:40 -06:00
Šimon Brandner
d162e021e1
Add message right click context menu v2 ( #5672 )
...
* migrate the message context menu to IconizedContextMenu
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* migrate the message context menu to IconizedContextMenu
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* Added right-click menu
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* add message context menu group keys
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* add message context menu icons
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* add _MessageContextMenu.scss license header
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
* use null vars for context menu lists
* Add allowOverridingNativeContextMenus()
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Use allowOverridingNativeContextMenus()
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove mistaken line
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix styling
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* InputHTMLAttributes -> AllHTMLAttributes
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Convert to TS
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add some types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Make onClick optional
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add rightClick prop
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add copy button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* What about upgrading deps after the eslint migration, Simon?
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add edit button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* fix
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add reply button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add react button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Cleanup render()
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix comments
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add save button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Don't show context menu if editing
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add special handling for click a timestamp
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix double empty line
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Don't show context menu for images
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Cleanup
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix order
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Keep action bar shown when right-clicking
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Highlight event tile when right-clicking
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Delint
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Pointless change so that I can re-run the CI
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove dowload button
Because we don't use this menu when clicking on images
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Be more clear for non-bools
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Use triggerOnMouse down prop
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove a comment
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove unused var
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove unnecessary import
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add some missing types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add missing type
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove unused import
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add a missing type
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix types
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix types/naming
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add missing current
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove unused var
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix editing and replying
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* i18n
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix import
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Support right-click context menu for threads
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Make button order match `MessageActionBar`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix missing permalink button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Remove useless part of if statement
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Some small refactoring for consistency
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Some more refactoring
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix `editEvent()` call
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Make editing polls work
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix collapse reply chain button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix timelineRenderingType
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Fix reply button
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Hide right-click context menu behind a labs flag
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add missing return type
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Make `contextMene` optional
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Move `renderContextMenu()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Simplify `renderContextMenu()`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Improve `aboveLeftOf` typing
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Use `InputHTMLAttributes`
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Disable message right-click context menu in browser (for now)
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Give permalink button more props
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Co-authored-by: Michael Weimann <mail@michael-weimann.eu>
2022-04-15 08:22:59 -06:00
Robin
d5887bf075
Fix rendering of hidden events ( #8334 )
2022-04-15 06:57:14 -04:00
Robin
7335b35fbb
Avoid looking up settings during timeline rendering ( #8313 )
...
* Avoid showHiddenEventsInTimeline lookups
* Avoid MSC3531 feature lookups
* Test that showHiddenEventsInTimeline doesn't get looked up while
rendering
* Fix code review nits
Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-04-14 23:23:22 +00:00
CommanderRoot
c35fc169f5
Replace deprecated String#substr with String#slice ( #8314 )
2022-04-14 07:52:42 +00:00