Consolidate random string generation to make Sonar happier (#8675)

* Consolidate random string generation to make Sonar happier

* Update snapshots
This commit is contained in:
Michael Telatynski 2022-05-24 09:05:11 +01:00 committed by GitHub
parent 9f1bffcd34
commit fe21ec8715
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 11 deletions

View file

@ -16,6 +16,7 @@ limitations under the License.
import React from 'react';
import { MatrixEvent } from 'matrix-js-sdk/src/models/event';
import { randomString } from 'matrix-js-sdk/src/randomstring';
import { _t } from '../../../languageHandler';
import Modal from '../../../Modal';
@ -45,10 +46,9 @@ export default class MLocationBody extends React.Component<IBodyProps, IState> {
constructor(props: IBodyProps) {
super(props);
const randomString = Math.random().toString(16).slice(2, 10);
// multiple instances of same map might be in document
// eg thread and main timeline, reply
const idSuffix = `${props.mxEvent.getId()}_${randomString}`;
const idSuffix = `${props.mxEvent.getId()}_${randomString(8)}`;
this.mapId = `mx_MLocationBody_${idSuffix}`;
this.state = {