imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Consolidate random string generation to make Sonar happier (#8675)

Browse source 
* Consolidate random string generation to make Sonar happier

* Update snapshots
This commit is contained in:
Michael Telatynski 2022-05-24 09:05:11 +01:00 • committed by GitHub
parent 9f1bffcd34
commit fe21ec8715
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/Analytics.tsx
View file

@ -18,6 +18,7 @@ limitations under the License.
import React from 'react';
import { logger } from "matrix-js-sdk/src/logger";
import { Optional } from "matrix-events-sdk";
import { randomString } from 'matrix-js-sdk/src/randomstring';
import { getCurrentLanguage, _t, _td, IVariables } from './languageHandler';
import PlatformPeg from './PlatformPeg';
@ -155,9 +156,9 @@ const LAST_VISIT_TS_KEY = "mx_Riot_Analytics_lvts";
function getUid(): string {
try {
let data = localStorage && localStorage.getItem(UID_KEY);
let data = localStorage?.getItem(UID_KEY);
if (!data && localStorage) {
localStorage.setItem(UID_KEY, data = [...Array(16)].map(() => Math.random().toString(16)[2]).join(''));
localStorage.setItem(UID_KEY, data = randomString(16));
}
return data;
} catch (e) {

4
src/components/views/messages/MLocationBody.tsx
View file

@ -16,6 +16,7 @@ limitations under the License.
import React from 'react';
import { MatrixEvent } from 'matrix-js-sdk/src/models/event';
import { randomString } from 'matrix-js-sdk/src/randomstring';
import { _t } from '../../../languageHandler';
import Modal from '../../../Modal';
@ -45,10 +46,9 @@ export default class MLocationBody extends React.Component<IBodyProps, IState> {
constructor(props: IBodyProps) {
super(props);
const randomString = Math.random().toString(16).slice(2, 10);
// multiple instances of same map might be in document
// eg thread and main timeline, reply
const idSuffix = `${props.mxEvent.getId()}_${randomString}`;
const idSuffix = `${props.mxEvent.getId()}_${randomString(8)}`;
this.mapId = `mx_MLocationBody_${idSuffix}`;
this.state = {

3
src/rageshake/rageshake.ts
View file

@ -39,6 +39,7 @@ limitations under the License.
// the frequency with which we flush to indexeddb
import { logger } from "matrix-js-sdk/src/logger";
import { randomString } from "matrix-js-sdk/src/randomstring";
import { getCircularReplacer } from "../utils/JSON";
@ -140,7 +141,7 @@ export class IndexedDBLogStore {
private indexedDB: IDBFactory,
private logger: ConsoleLogger,
) {
this.id = "instance-" + Math.random() + Date.now();
this.id = "instance-" + randomString(16);
}
/**