imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Delete groups (legacy communities system) (#8027)

Browse source 
* Remove deprecated feature_communities_v2_prototypes

* Update _components

* i18n

* delint

* Cut out a bit more dead code

* Carve into legacy components

* Carve into mostly the room list code

* Carve into instances of "groupId"

* Carve out more of what comes up with "groups"

* Carve out some settings

* ignore related groups state

* Remove instances of spacesEnabled

* Fix some obvious issues

* Remove now-unused css

* Fix variable naming for legacy components

* Update i18n

* Misc cleanup from manual review

* Update snapshot for changed flag

* Appease linters

* rethemedex

* Remove now-unused AddressPickerDialog

* Make ConfirmUserActionDialog's member a required prop

* Remove useless override from RightPanelStore

* Remove extraneous CSS

* Update i18n

* Demo: "Communities are now Spaces" landing page

* Restore linkify for group IDs

* Demo: Dialog on click for communities->spaces notice

* i18n for demos

* i18n post-merge

* Update copy

* Appease the linter

* Post-merge cleanup

* Re-add spaces_learn_more_url to the new SdkConfig place

* Round 1 of post-merge fixes

* i18n

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Travis Ralston 2022-03-22 17:07:37 -06:00 • committed by GitHub
parent 03c80707c9
commit fce36ec826
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
171 changed files with 317 additions and 12160 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/components/views/context_menus/SpaceContextMenu-test.tsx
View file

@ -48,9 +48,6 @@ jest.mock('../../../../src/utils/space', () => ({
showSpacePreferences: jest.fn(),
showSpaceSettings: jest.fn(),
}));
jest.mock('../../../../src/stores/spaces/SpaceStore', () => ({
spacesEnabled: true,
}));
describe('<SpaceContextMenu />', () => {
const userId = '@test:server';

148
test/components/views/groups/GroupMemberList-test.js
View file

@ -1,148 +0,0 @@
/*
Copyright 2018 New Vector Ltd.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
import React from "react";
import ReactDOM from "react-dom";
import ReactTestUtils from "react-dom/test-utils";
import MockHttpBackend from "matrix-mock-request";
import * as Matrix from "matrix-js-sdk/src/matrix";
import { MatrixClientPeg } from "../../../../src/MatrixClientPeg";
import sdk from "../../../skinned-sdk";
import * as TestUtils from "../../../test-utils";
const { waitForUpdate } = TestUtils;
const GroupMemberList = sdk.getComponent("views.groups.GroupMemberList");
const WrappedGroupMemberList = TestUtils.wrapInMatrixClientContext(GroupMemberList);
describe("GroupMemberList", function() {
let root;
let rootElement;
let httpBackend;
let summaryResponse;
let groupId;
let groupIdEncoded;
// Summary response fields
const user = {
is_privileged: true, // can edit the group
is_public: true, // appear as a member to non-members
is_publicised: true, // display flair
};
const usersSection = {
roles: {},
total_user_count_estimate: 0,
users: [],
};
const roomsSection = {
categories: {},
rooms: [],
total_room_count_estimate: 0,
};
// Users response fields
const usersResponse = {
chunk: [
{
user_id: "@test:matrix.org",
displayname: "Test",
avatar_url: "mxc://matrix.org/oUxxDyzQOHdVDMxgwFzyCWEe",
is_public: true,
is_privileged: true,
attestation: {},
},
],
};
beforeEach(function() {
httpBackend = new MockHttpBackend();
Matrix.request(httpBackend.requestFn);
MatrixClientPeg.get = () => Matrix.createClient({
baseUrl: "https://my.home.server",
userId: "@me:here",
accessToken: "123456789",
});
summaryResponse = {
profile: {
avatar_url: "mxc://someavatarurl",
is_openly_joinable: true,
is_public: true,
long_description: "This is a <b>LONG</b> description.",
name: "The name of a community",
short_description: "This is a community",
},
user,
users_section: usersSection,
rooms_section: roomsSection,
};
groupId = "+" + Math.random().toString(16).slice(2) + ":domain";
groupIdEncoded = encodeURIComponent(groupId);
rootElement = document.createElement("div");
root = ReactDOM.render(<WrappedGroupMemberList groupId={groupId} />, rootElement);
});
afterEach(function() {
ReactDOM.unmountComponentAtNode(rootElement);
});
it("should show group member list after successful /users", function() {
const groupMemberList = ReactTestUtils.findRenderedComponentWithType(root, GroupMemberList);
const prom = waitForUpdate(groupMemberList, 4).then(() => {
ReactTestUtils.findRenderedDOMComponentWithClass(root, "mx_MemberList");
const memberList = ReactTestUtils.findRenderedDOMComponentWithClass(root, "mx_MemberList_joined");
const memberListElement = ReactDOM.findDOMNode(memberList);
expect(memberListElement).toBeTruthy();
const userNameElement = memberListElement.querySelector(".mx_EntityTile_name");
expect(userNameElement).toBeTruthy();
expect(userNameElement.textContent).toBe("Test");
});
httpBackend.when("GET", "/groups/" + groupIdEncoded + "/summary").respond(200, summaryResponse);
httpBackend.when("GET", "/groups/" + groupIdEncoded + "/users").respond(200, usersResponse);
httpBackend.when("GET", "/groups/" + groupIdEncoded + "/invited_users").respond(200, { chunk: [] });
httpBackend.when("GET", "/groups/" + groupIdEncoded + "/rooms").respond(200, { chunk: [] });
httpBackend.flush(undefined, undefined, 0);
return prom;
});
it("should show error message after failed /users", function() {
const groupMemberList = ReactTestUtils.findRenderedComponentWithType(root, GroupMemberList);
const prom = waitForUpdate(groupMemberList, 4).then(() => {
ReactTestUtils.findRenderedDOMComponentWithClass(root, "mx_MemberList");
const memberList = ReactTestUtils.findRenderedDOMComponentWithClass(root, "mx_MemberList_joined");
const memberListElement = ReactDOM.findDOMNode(memberList);
expect(memberListElement).toBeTruthy();
expect(memberListElement.textContent).toBe("Failed to load group members");
});
httpBackend.when("GET", "/groups/" + groupIdEncoded + "/summary").respond(200, summaryResponse);
httpBackend.when("GET", "/groups/" + groupIdEncoded + "/users").respond(500, {});
httpBackend.when("GET", "/groups/" + groupIdEncoded + "/invited_users").respond(200, { chunk: [] });
httpBackend.when("GET", "/groups/" + groupIdEncoded + "/rooms").respond(200, { chunk: [] });
httpBackend.flush(undefined, undefined, 0);
return prom;
});
});

4
test/components/views/rooms/RoomTile-test.tsx
View file

@ -18,6 +18,7 @@ import React from "react";
import { mount } from "enzyme";
import { act } from "react-dom/test-utils";
import { ClientWidgetApi, MatrixWidgetType } from "matrix-widget-api";
import { mocked } from "jest-mock";
import "../../../skinned-sdk";
import { stubClient, mkStubRoom } from "../../../test-utils";
@ -30,9 +31,8 @@ import VoiceChannelStore, { VoiceChannelEvent } from "../../../../src/stores/Voi
import { DefaultTagID } from "../../../../src/stores/room-list/models";
import DMRoomMap from "../../../../src/utils/DMRoomMap";
import { VOICE_CHANNEL_ID } from "../../../../src/utils/VoiceChannelUtils";
import { mocked } from "jest-mock";
import { MatrixClientPeg } from "../../../../src/MatrixClientPeg";
import PlatformPeg from "../../../../src/PlatformPeg";
import PlatformPeg from "../../../../src/PlatformPeg";
import BasePlatform from "../../../../src/BasePlatform";
describe("RoomTile", () => {

2
test/components/views/settings/UiFeatureSettingWrapper-test.tsx
View file

@ -25,7 +25,7 @@ jest.mock('../../../../src/settings/SettingsStore');
describe('<UiFeatureSettingWrapper>', () => {
const defaultProps = {
uiFeature: UIFeature.Flair,
uiFeature: UIFeature.Feedback,
children: <div>test</div>,
};
const getComponent = (props = {}) => mount(<UiFeatureSettingWrapper {...defaultProps} {...props} />);

2
test/components/views/settings/__snapshots__/UiFeatureSettingWrapper-test.tsx.snap
View file

@ -2,7 +2,7 @@
exports[`<UiFeatureSettingWrapper> renders children when setting is truthy 1`] = `
<UiFeatureSettingWrapper
uiFeature="UIFeature.flair"
uiFeature="UIFeature.feedback"
>
<div>
test

2
test/components/views/voip/VoiceChannelRadio-test.tsx
View file

@ -18,13 +18,13 @@ import { EventEmitter } from "events";
import React from "react";
import { mount } from "enzyme";
import { act } from "react-dom/test-utils";
import { mocked } from "jest-mock";
import "../../../skinned-sdk";
import { stubClient, mkStubRoom, wrapInMatrixClientContext } from "../../../test-utils";
import _VoiceChannelRadio from "../../../../src/components/views/voip/VoiceChannelRadio";
import VoiceChannelStore, { VoiceChannelEvent } from "../../../../src/stores/VoiceChannelStore";
import DMRoomMap from "../../../../src/utils/DMRoomMap";
import { mocked } from "jest-mock";
import { MatrixClientPeg } from "../../../../src/MatrixClientPeg";
const VoiceChannelRadio = wrapInMatrixClientContext(_VoiceChannelRadio);