imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #6487 from matrix-org/gsouquet/fix-18265

Browse source
This commit is contained in:
Germain 2021-07-27 17:20:02 +01:00 • committed by GitHub
commit f82744db97
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/views/rooms/ReplyTile.tsx
View file

@ -67,6 +67,11 @@ export default class ReplyTile extends React.PureComponent<IProps> {
}; };
private onClick = (e: React.MouseEvent): void => { private onClick = (e: React.MouseEvent): void => {
const clickTarget = e.target as HTMLElement;
// Following a link within a reply should not dispatch the `view_room` action
// so that the browser can direct the user to the correct location
// The exception being the link wrapping the reply
if (clickTarget.tagName.toLowerCase() !== "a" || clickTarget.closest("a") === null) {
// This allows the permalink to be opened in a new tab/window or copied as // This allows the permalink to be opened in a new tab/window or copied as
// matrix.to, but also for it to enable routing within Riot when clicked. // matrix.to, but also for it to enable routing within Riot when clicked.
e.preventDefault(); e.preventDefault();
@ -76,6 +81,7 @@ export default class ReplyTile extends React.PureComponent<IProps> {
highlighted: true, highlighted: true,
room_id: this.props.mxEvent.getRoomId(), room_id: this.props.mxEvent.getRoomId(),
}); });
}
}; };
render() { render() {