Merge pull request #5370 from matrix-org/t3chguy/countly

Fix CountlyAnalytics NPE on MatrixClientPeg
This commit is contained in:
Michael Telatynski 2020-10-30 14:28:48 +00:00 committed by GitHub
commit f80ee391bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 7 deletions

View file

@ -350,10 +350,8 @@ export default class MatrixChat extends React.PureComponent<IProps, IState> {
if (SettingsStore.getValue("analyticsOptIn")) {
Analytics.enable();
CountlyAnalytics.instance.enable(false);
} else {
CountlyAnalytics.instance.enable(true);
}
CountlyAnalytics.instance.enable(/* anonymous = */ true);
}
// TODO: [REACT-WARNING] Replace with appropriate lifecycle stage
@ -422,7 +420,7 @@ export default class MatrixChat extends React.PureComponent<IProps, IState> {
dis.dispatch({action: "view_welcome_page"});
}
} else if (SettingsStore.getValue("analyticsOptIn")) {
CountlyAnalytics.instance.enable(false);
CountlyAnalytics.instance.enable(/* anonymous = */ false);
}
});
// Note we don't catch errors from this: we catch everything within
@ -762,7 +760,7 @@ export default class MatrixChat extends React.PureComponent<IProps, IState> {
Analytics.enable();
}
if (CountlyAnalytics.instance.canEnable()) {
CountlyAnalytics.instance.enable(false);
CountlyAnalytics.instance.enable(/* anonymous = */ false);
}
break;
case 'reject_cookies':