From f80cbebb9dd79a3aa0e9c15e99fff9b6d51b73ad Mon Sep 17 00:00:00 2001 From: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Date: Mon, 5 Aug 2019 10:34:46 +0100 Subject: [PATCH] Don't switch rooms when forgetting a room (#3275) Don't randomly change to another room upon forgetting a room. --- .../views/context_menus/RoomTileContextMenu.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/components/views/context_menus/RoomTileContextMenu.js b/src/components/views/context_menus/RoomTileContextMenu.js index f494fbd961..c6a4d54487 100644 --- a/src/components/views/context_menus/RoomTileContextMenu.js +++ b/src/components/views/context_menus/RoomTileContextMenu.js @@ -30,6 +30,7 @@ import * as Rooms from '../../../Rooms'; import * as RoomNotifs from '../../../RoomNotifs'; import Modal from '../../../Modal'; import RoomListActions from '../../../actions/RoomListActions'; +import RoomViewStore from '../../../stores/RoomViewStore'; module.exports = React.createClass({ displayName: 'RoomTileContextMenu', @@ -158,8 +159,12 @@ module.exports = React.createClass({ _onClickForget: function() { // FIXME: duplicated with RoomSettings (and dead code in RoomView) - MatrixClientPeg.get().forget(this.props.room.roomId).done(function() { - dis.dispatch({ action: 'view_next_room' }); + MatrixClientPeg.get().forget(this.props.room.roomId).done(() => { + // Switch to another room view if we're currently viewing the + // historical room + if (RoomViewStore.getRoomId() === this.props.room.roomId) { + dis.dispatch({ action: 'view_next_room' }); + } }, function(err) { const errCode = err.errcode || _td("unknown error code"); const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");