imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make more of the codebase conform to strict types (#10859)

Browse source
This commit is contained in:
Michael Telatynski 2023-05-12 09:49:37 +01:00 • committed by GitHub
parent 6f58dd49e3
commit f758cbd38a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
46 changed files with 111 additions and 105 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/views/settings/ProfileSettings.tsx
View file

@ -24,7 +24,7 @@ import { OwnProfileStore } from "../../../stores/OwnProfileStore";
import Modal from "../../../Modal";
import ErrorDialog from "../dialogs/ErrorDialog";
import { mediaFromMxc } from "../../../customisations/Media";
import AccessibleButton from "../elements/AccessibleButton";
import AccessibleButton, { ButtonEvent } from "../elements/AccessibleButton";
import AvatarSetting from "./AvatarSetting";
import UserIdentifierCustomisations from "../../../customisations/UserIdentifier";
import { chromeFileInputFix } from "../../../utils/BrowserWorkarounds";
@ -75,7 +75,7 @@ export default class ProfileSettings extends React.Component<{}, IState> {
});
};
private cancelProfileChanges = async (e: React.MouseEvent): Promise<void> => {
private cancelProfileChanges = async (e: ButtonEvent): Promise<void> => {
e.stopPropagation();
e.preventDefault();
@ -88,7 +88,7 @@ export default class ProfileSettings extends React.Component<{}, IState> {
});
};
private saveProfile = async (e: React.FormEvent<HTMLFormElement>): Promise<void> => {
private saveProfile = async (e: ButtonEvent): Promise<void> => {
e.stopPropagation();
e.preventDefault();

10
src/components/views/settings/account/EmailAddresses.tsx
View file

@ -23,7 +23,7 @@ import { MatrixError } from "matrix-js-sdk/src/matrix";
import { _t, UserFriendlyError } from "../../../../languageHandler";
import { MatrixClientPeg } from "../../../../MatrixClientPeg";
import Field from "../../elements/Field";
import AccessibleButton from "../../elements/AccessibleButton";
import AccessibleButton, { ButtonEvent } from "../../elements/AccessibleButton";
import * as Email from "../../../../email";
import AddThreepid from "../../../../AddThreepid";
import Modal from "../../../../Modal";
@ -59,21 +59,21 @@ export class ExistingEmailAddress extends React.Component<IExistingEmailAddressP
};
}
private onRemove = (e: React.MouseEvent): void => {
private onRemove = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
this.setState({ verifyRemove: true });
};
private onDontRemove = (e: React.MouseEvent): void => {
private onDontRemove = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
this.setState({ verifyRemove: false });
};
private onActuallyRemove = (e: React.MouseEvent): void => {
private onActuallyRemove = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
@ -196,7 +196,7 @@ export default class EmailAddresses extends React.Component<IProps, IState> {
});
};
private onContinueClick = (e: React.MouseEvent): void => {
private onContinueClick = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();

12
src/components/views/settings/account/PhoneNumbers.tsx
View file

@ -22,7 +22,7 @@ import { logger } from "matrix-js-sdk/src/logger";
import { _t, UserFriendlyError } from "../../../../languageHandler";
import { MatrixClientPeg } from "../../../../MatrixClientPeg";
import Field from "../../elements/Field";
import AccessibleButton from "../../elements/AccessibleButton";
import AccessibleButton, { ButtonEvent } from "../../elements/AccessibleButton";
import AddThreepid from "../../../../AddThreepid";
import CountryDropdown from "../../auth/CountryDropdown";
import Modal from "../../../../Modal";
@ -54,21 +54,21 @@ export class ExistingPhoneNumber extends React.Component<IExistingPhoneNumberPro
};
}
private onRemove = (e: React.MouseEvent): void => {
private onRemove = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
this.setState({ verifyRemove: true });
};
private onDontRemove = (e: React.MouseEvent): void => {
private onDontRemove = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
this.setState({ verifyRemove: false });
};
private onActuallyRemove = (e: React.MouseEvent): void => {
private onActuallyRemove = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
@ -173,7 +173,7 @@ export default class PhoneNumbers extends React.Component<IProps, IState> {
});
};
private onAddClick = (e: React.MouseEvent | React.FormEvent): void => {
private onAddClick = (e: ButtonEvent | React.FormEvent): void => {
e.stopPropagation();
e.preventDefault();
@ -199,7 +199,7 @@ export default class PhoneNumbers extends React.Component<IProps, IState> {
});
};
private onContinueClick = (e: React.MouseEvent | React.FormEvent): void => {
private onContinueClick = (e: ButtonEvent | React.FormEvent): void => {
e.stopPropagation();
e.preventDefault();

6
src/components/views/settings/devices/DeviceDetailHeading.tsx
View file

@ -14,10 +14,10 @@ See the License for the specific language governing permissions and
limitations under the License.
*/
import React, { FormEvent, useEffect, useState } from "react";
import React, { useEffect, useState } from "react";
import { _t } from "../../../../languageHandler";
import AccessibleButton from "../../elements/AccessibleButton";
import AccessibleButton, { ButtonEvent } from "../../elements/AccessibleButton";
import Field from "../../elements/Field";
import LearnMore from "../../elements/LearnMore";
import Spinner from "../../elements/Spinner";
@ -41,7 +41,7 @@ const DeviceNameEditor: React.FC<Props & { stopEditing: () => void }> = ({ devic
const onInputChange = (event: React.ChangeEvent<HTMLInputElement>): void => setDeviceName(event.target.value);
const onSubmit = async (event: FormEvent<HTMLFormElement>): Promise<void> => {
const onSubmit = async (event: ButtonEvent): Promise<void> => {
setIsLoading(true);
setError(null);
event.preventDefault();

8
src/components/views/settings/discovery/EmailAddresses.tsx
View file

@ -25,7 +25,7 @@ import { MatrixClientPeg } from "../../../../MatrixClientPeg";
import Modal from "../../../../Modal";
import AddThreepid, { Binding } from "../../../../AddThreepid";
import ErrorDialog, { extractErrorMessageFromError } from "../../dialogs/ErrorDialog";
import AccessibleButton from "../../elements/AccessibleButton";
import AccessibleButton, { ButtonEvent } from "../../elements/AccessibleButton";
/*
TODO: Improve the UX for everything in here.
@ -147,7 +147,7 @@ export class EmailAddress extends React.Component<IEmailAddressProps, IEmailAddr
}
}
private onRevokeClick = (e: React.MouseEvent): void => {
private onRevokeClick = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
this.changeBinding({
@ -157,7 +157,7 @@ export class EmailAddress extends React.Component<IEmailAddressProps, IEmailAddr
});
};
private onShareClick = (e: React.MouseEvent): void => {
private onShareClick = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
this.changeBinding({
@ -167,7 +167,7 @@ export class EmailAddress extends React.Component<IEmailAddressProps, IEmailAddr
});
};
private onContinueClick = async (e: React.MouseEvent): Promise<void> => {
private onContinueClick = async (e: ButtonEvent): Promise<void> => {
e.stopPropagation();
e.preventDefault();

8
src/components/views/settings/discovery/PhoneNumbers.tsx
View file

@ -26,7 +26,7 @@ import Modal from "../../../../Modal";
import AddThreepid, { Binding } from "../../../../AddThreepid";
import ErrorDialog, { extractErrorMessageFromError } from "../../dialogs/ErrorDialog";
import Field from "../../elements/Field";
import AccessibleButton from "../../elements/AccessibleButton";
import AccessibleButton, { ButtonEvent } from "../../elements/AccessibleButton";
/*
TODO: Improve the UX for everything in here.
@ -154,7 +154,7 @@ export class PhoneNumber extends React.Component<IPhoneNumberProps, IPhoneNumber
}
}
private onRevokeClick = (e: React.MouseEvent): void => {
private onRevokeClick = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
this.changeBinding({
@ -164,7 +164,7 @@ export class PhoneNumber extends React.Component<IPhoneNumberProps, IPhoneNumber
});
};
private onShareClick = (e: React.MouseEvent): void => {
private onShareClick = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
this.changeBinding({
@ -180,7 +180,7 @@ export class PhoneNumber extends React.Component<IPhoneNumberProps, IPhoneNumber
});
};
private onContinueClick = async (e: React.MouseEvent | React.FormEvent): Promise<void> => {
private onContinueClick = async (e: ButtonEvent | React.FormEvent): Promise<void> => {
e.stopPropagation();
e.preventDefault();

2
src/components/views/settings/tabs/room/GeneralRoomSettingsTab.tsx
View file

@ -41,7 +41,7 @@ interface IState {
export default class GeneralRoomSettingsTab extends React.Component<IProps, IState> {
public static contextType = MatrixClientContext;
public context: ContextType<typeof MatrixClientContext>;
public context!: ContextType<typeof MatrixClientContext>;
public constructor(props: IProps, context: ContextType<typeof MatrixClientContext>) {
super(props, context);

6
src/components/views/settings/tabs/room/NotificationSettingsTab.tsx
View file

@ -70,7 +70,7 @@ export default class NotificationsSettingsTab extends React.Component<IProps, IS
};
}
private triggerUploader = async (e: React.MouseEvent): Promise<void> => {
private triggerUploader = async (e: ButtonEvent): Promise<void> => {
e.stopPropagation();
e.preventDefault();
@ -91,7 +91,7 @@ export default class NotificationsSettingsTab extends React.Component<IProps, IS
});
};
private onClickSaveSound = async (e: React.MouseEvent): Promise<void> => {
private onClickSaveSound = async (e: ButtonEvent): Promise<void> => {
e.stopPropagation();
e.preventDefault();
@ -133,7 +133,7 @@ export default class NotificationsSettingsTab extends React.Component<IProps, IS
});
}
private clearSound = (e: React.MouseEvent): void => {
private clearSound = (e: ButtonEvent): void => {
e.stopPropagation();
e.preventDefault();
SettingsStore.setValue("notificationSound", this.props.roomId, SettingLevel.ROOM_ACCOUNT, null);