imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prefer null to falsy, use correct plural

Browse source
This commit is contained in:
Luke Barnard 2016-11-10 15:38:20 +00:00
parent 1a4df38500
commit f71ac93946
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/components/views/elements/MemberEventListSummary.js
View file

@ -103,7 +103,7 @@ module.exports = React.createClass({
</span> </span>
); );
} }
let leaveSummary = ''; let leaveSummary = null;
if (leavers) { if (leavers) {
leaveSummary = ( leaveSummary = (
<span> <span>
@ -186,7 +186,8 @@ module.exports = React.createClass({
toggleButton = ( toggleButton = (
<a onClick={this._toggleSummary}>{expanded?'collapse':'expand'}</a> <a onClick={this._toggleSummary}>{expanded?'collapse':'expand'}</a>
); );
let noun = (joinAndLeft === 1 ? 'user' : 'others'); let plural = (joinEvents.length + leaveEvents.length > 0) ? 'others' : 'users';
let noun = (joinAndLeft === 1 ? 'user' : plural);
summaryContainer = ( summaryContainer = (
<div className="mx_EventTile_line"> <div className="mx_EventTile_line">