From f28c396b1eec1f91b52e01c1db3c227ba2370ed3 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Fri, 4 Sep 2020 12:14:43 +0100 Subject: [PATCH] Fix HeaderButtons handler bindings --- .../views/right_panel/GroupHeaderButtons.tsx | 10 ++++------ .../views/right_panel/RoomHeaderButtons.tsx | 12 ++++++------ 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/src/components/views/right_panel/GroupHeaderButtons.tsx b/src/components/views/right_panel/GroupHeaderButtons.tsx index c468658eb6..dd4a82e645 100644 --- a/src/components/views/right_panel/GroupHeaderButtons.tsx +++ b/src/components/views/right_panel/GroupHeaderButtons.tsx @@ -41,8 +41,6 @@ interface IProps {} export default class GroupHeaderButtons extends HeaderButtons { constructor(props: IProps) { super(props, HeaderKind.Group); - this.onMembersClicked = this.onMembersClicked.bind(this); - this.onRoomsClicked = this.onRoomsClicked.bind(this); } protected onAction(payload: ActionPayload) { @@ -68,7 +66,7 @@ export default class GroupHeaderButtons extends HeaderButtons { } } - private onMembersClicked() { + private onMembersClicked = () => { if (this.state.phase === RightPanelPhases.GroupMemberInfo) { // send the active phase to trigger a toggle this.setPhase(RightPanelPhases.GroupMemberInfo); @@ -76,12 +74,12 @@ export default class GroupHeaderButtons extends HeaderButtons { // This toggles for us, if needed this.setPhase(RightPanelPhases.GroupMemberList); } - } + }; - private onRoomsClicked() { + private onRoomsClicked = () => { // This toggles for us, if needed this.setPhase(RightPanelPhases.GroupRoomList); - } + }; renderButtons() { return [ diff --git a/src/components/views/right_panel/RoomHeaderButtons.tsx b/src/components/views/right_panel/RoomHeaderButtons.tsx index 671d9b0068..7d732b8ae3 100644 --- a/src/components/views/right_panel/RoomHeaderButtons.tsx +++ b/src/components/views/right_panel/RoomHeaderButtons.tsx @@ -54,7 +54,7 @@ export default class RoomHeaderButtons extends HeaderButtons { } } - private onMembersClicked() { + private onMembersClicked = () => { if (this.state.phase === RightPanelPhases.RoomMemberInfo) { // send the active phase to trigger a toggle // XXX: we should pass refireParams here but then it won't collapse as we desire it to @@ -63,17 +63,17 @@ export default class RoomHeaderButtons extends HeaderButtons { // This toggles for us, if needed this.setPhase(RightPanelPhases.RoomMemberList); } - } + }; - private onFilesClicked() { + private onFilesClicked = () => { // This toggles for us, if needed this.setPhase(RightPanelPhases.FilePanel); - } + }; - private onNotificationsClicked() { + private onNotificationsClicked = () => { // This toggles for us, if needed this.setPhase(RightPanelPhases.NotificationPanel); - } + }; public renderButtons() { return [