Enable @typescript-eslint/explicit-member-accessibility on /src (#9785)

* Enable `@typescript-eslint/explicit-member-accessibility` on /src

* Prettier

src/components/views/settings/BridgeTile.tsx

@@ -65,7 +65,7 @@ interface IBridgeStateEvent {
 }
 
 export default class BridgeTile extends React.PureComponent<IProps> {
-    render() {
+    public render() {
         const content: IBridgeStateEvent = this.props.ev.getContent();
         // Validate
         if (!content.channel?.id || !content.protocol?.id) {

src/components/views/settings/ChangePassword.tsx

@@ -74,7 +74,7 @@ export default class ChangePassword extends React.Component<IProps, IState> {
         confirm: true,
     };
 
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {

src/components/views/settings/CrossSigningPanel.tsx

@@ -43,7 +43,7 @@ interface IState {
 export default class CrossSigningPanel extends React.PureComponent<{}, IState> {
     private unmounted = false;
 
-    constructor(props) {
+    public constructor(props) {
         super(props);
 
         this.state = {};

src/components/views/settings/CryptographyPanel.tsx

@@ -30,7 +30,7 @@ interface IProps {}
 interface IState {}
 
 export default class CryptographyPanel extends React.Component<IProps, IState> {
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
     }
 

src/components/views/settings/DevicesPanel.tsx

@@ -45,7 +45,7 @@ export default class DevicesPanel extends React.Component<IProps, IState> {
     public context!: React.ContextType<typeof MatrixClientContext>;
     private unmounted = false;
 
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
         this.state = {
             devices: [],

src/components/views/settings/DevicesPanelEntry.tsx

@@ -47,7 +47,7 @@ interface IState {
 }
 
 export default class DevicesPanelEntry extends React.Component<IProps, IState> {
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
         this.state = {
             renaming: false,

src/components/views/settings/EventIndexPanel.tsx

@@ -35,7 +35,7 @@ interface IState {
 }
 
 export default class EventIndexPanel extends React.Component<{}, IState> {
-    constructor(props) {
+    public constructor(props) {
         super(props);
 
         this.state = {
@@ -46,7 +46,7 @@ export default class EventIndexPanel extends React.Component<{}, IState> {
         };
     }
 
-    updateCurrentRoom = async (room) => {
+    public updateCurrentRoom = async () => {
         const eventIndex = EventIndexPeg.get();
         let stats;
 
@@ -64,7 +64,7 @@ export default class EventIndexPanel extends React.Component<{}, IState> {
         });
     };
 
-    componentWillUnmount(): void {
+    public componentWillUnmount(): void {
         const eventIndex = EventIndexPeg.get();
 
         if (eventIndex !== null) {
@@ -72,11 +72,11 @@ export default class EventIndexPanel extends React.Component<{}, IState> {
         }
     }
 
-    componentDidMount(): void {
+    public componentDidMount(): void {
         this.updateState();
     }
 
-    async updateState() {
+    public async updateState() {
         const eventIndex = EventIndexPeg.get();
         const eventIndexingEnabled = SettingsStore.getValueAt(SettingLevel.DEVICE, "enableEventIndexing");
         const enabling = false;
@@ -145,7 +145,7 @@ export default class EventIndexPanel extends React.Component<{}, IState> {
         });
     };
 
-    render() {
+    public render() {
         let eventIndexingSettings = null;
         const brand = SdkConfig.get().brand;
 

src/components/views/settings/FontScalingPanel.tsx

@@ -48,7 +48,7 @@ export default class FontScalingPanel extends React.Component<IProps, IState> {
 
     private unmounted = false;
 
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {
@@ -61,7 +61,7 @@ export default class FontScalingPanel extends React.Component<IProps, IState> {
         };
     }
 
-    async componentDidMount() {
+    public async componentDidMount() {
         // Fetch the current user profile for the message preview
         const client = MatrixClientPeg.get();
         const userId = client.getUserId();
@@ -75,7 +75,7 @@ export default class FontScalingPanel extends React.Component<IProps, IState> {
         });
     }
 
-    componentWillUnmount() {
+    public componentWillUnmount() {
         this.unmounted = true;
     }
 

src/components/views/settings/ImageSizePanel.tsx

@@ -31,7 +31,7 @@ interface IState {
 }
 
 export default class ImageSizePanel extends React.Component<IProps, IState> {
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {

src/components/views/settings/LayoutSwitcher.tsx

@@ -39,7 +39,7 @@ interface IState {
 }
 
 export default class LayoutSwitcher extends React.Component<IProps, IState> {
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {

src/components/views/settings/ProfileSettings.tsx

@@ -45,7 +45,7 @@ interface IState {
 export default class ProfileSettings extends React.Component<{}, IState> {
     private avatarUpload: React.RefObject<HTMLInputElement> = createRef();
 
-    constructor(props: {}) {
+    public constructor(props: {}) {
         super(props);
 
         const client = MatrixClientPeg.get();

src/components/views/settings/SecureBackupPanel.tsx

@@ -47,7 +47,7 @@ interface IState {
 export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
     private unmounted = false;
 
-    constructor(props: {}) {
+    public constructor(props: {}) {
         super(props);
 
         this.state = {

src/components/views/settings/SetIdServer.tsx

@@ -82,7 +82,7 @@ interface IState {
 export default class SetIdServer extends React.Component<IProps, IState> {
     private dispatcherRef: string;
 
-    constructor(props) {
+    public constructor(props) {
         super(props);
 
         let defaultIdServer = "";
@@ -103,11 +103,11 @@ export default class SetIdServer extends React.Component<IProps, IState> {
         };
     }
 
-    componentDidMount(): void {
+    public componentDidMount(): void {
         this.dispatcherRef = dis.register(this.onAction);
     }
 
-    componentWillUnmount(): void {
+    public componentWillUnmount(): void {
         dis.unregister(this.dispatcherRef);
     }
 
@@ -372,7 +372,7 @@ export default class SetIdServer extends React.Component<IProps, IState> {
         });
     };
 
-    render() {
+    public render() {
         const idServerUrl = this.state.currentClientIdServer;
         let sectionTitle;
         let bodyText;

src/components/views/settings/SetIntegrationManager.tsx

@@ -32,7 +32,7 @@ interface IState {
 }
 
 export default class SetIntegrationManager extends React.Component<IProps, IState> {
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         const currentManager = IntegrationManagers.sharedInstance().getPrimaryManager();

src/components/views/settings/SpellCheckSettings.tsx

@@ -42,7 +42,7 @@ export class ExistingSpellCheckLanguage extends React.Component<ExistingSpellChe
         return this.props.onRemoved(this.props.language);
     };
 
-    render() {
+    public render() {
         return (
             <div className="mx_ExistingSpellCheckLanguage">
                 <span className="mx_ExistingSpellCheckLanguage_language">{this.props.language}</span>
@@ -55,7 +55,7 @@ export class ExistingSpellCheckLanguage extends React.Component<ExistingSpellChe
 }
 
 export default class SpellCheckLanguages extends React.Component<SpellCheckLanguagesIProps, SpellCheckLanguagesIState> {
-    constructor(props) {
+    public constructor(props) {
         super(props);
         this.state = {
             newLanguage: "",
@@ -86,7 +86,7 @@ export default class SpellCheckLanguages extends React.Component<SpellCheckLangu
         this.setState({ newLanguage: language });
     };
 
-    render() {
+    public render() {
         const existingSpellCheckLanguages = this.props.languages.map((e) => {
             return <ExistingSpellCheckLanguage language={e} onRemoved={this.onRemoved} key={e} />;
         });

src/components/views/settings/ThemeChoicePanel.tsx

@@ -51,7 +51,7 @@ interface IState extends IThemeState {
 export default class ThemeChoicePanel extends React.Component<IProps, IState> {
     private themeTimer: number;
 
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {
@@ -268,7 +268,7 @@ export default class ThemeChoicePanel extends React.Component<IProps, IState> {
         );
     }
 
-    apparentSelectedThemeId() {
+    public apparentSelectedThemeId() {
         if (this.state.useSystemTheme) {
             return undefined;
         }

src/components/views/settings/account/EmailAddresses.tsx

@@ -50,7 +50,7 @@ interface IExistingEmailAddressState {
 }
 
 export class ExistingEmailAddress extends React.Component<IExistingEmailAddressProps, IExistingEmailAddressState> {
-    constructor(props: IExistingEmailAddressProps) {
+    public constructor(props: IExistingEmailAddressProps) {
         super(props);
 
         this.state = {
@@ -139,7 +139,7 @@ interface IState {
 }
 
 export default class EmailAddresses extends React.Component<IProps, IState> {
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {

src/components/views/settings/account/PhoneNumbers.tsx

@@ -46,7 +46,7 @@ interface IExistingPhoneNumberState {
 }
 
 export class ExistingPhoneNumber extends React.Component<IExistingPhoneNumberProps, IExistingPhoneNumberState> {
-    constructor(props: IExistingPhoneNumberProps) {
+    public constructor(props: IExistingPhoneNumberProps) {
         super(props);
 
         this.state = {
@@ -139,7 +139,7 @@ interface IState {
 }
 
 export default class PhoneNumbers extends React.Component<IProps, IState> {
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {

src/components/views/settings/discovery/EmailAddresses.tsx

@@ -54,7 +54,7 @@ interface IEmailAddressState {
 }
 
 export class EmailAddress extends React.Component<IEmailAddressProps, IEmailAddressState> {
-    constructor(props: IEmailAddressProps) {
+    public constructor(props: IEmailAddressProps) {
         super(props);
 
         const { bound } = props.email;

src/components/views/settings/discovery/PhoneNumbers.tsx

@@ -48,7 +48,7 @@ interface IPhoneNumberState {
 }
 
 export class PhoneNumber extends React.Component<IPhoneNumberProps, IPhoneNumberState> {
-    constructor(props: IPhoneNumberProps) {
+    public constructor(props: IPhoneNumberProps) {
         super(props);
 
         const { bound } = props.msisdn;

src/components/views/settings/tabs/room/AdvancedRoomSettingsTab.tsx

@@ -46,7 +46,7 @@ interface IState {
 }
 
 export default class AdvancedRoomSettingsTab extends React.Component<IProps, IState> {
-    constructor(props, context) {
+    public constructor(props, context) {
         super(props, context);
 
         this.state = {
@@ -94,7 +94,7 @@ export default class AdvancedRoomSettingsTab extends React.Component<IProps, ISt
         this.props.closeSettingsFn();
     };
 
-    render() {
+    public render() {
         const client = MatrixClientPeg.get();
         const room = client.getRoom(this.props.roomId);
         const isSpace = room.isSpaceRoom();

src/components/views/settings/tabs/room/BridgeSettingsTab.tsx

@@ -42,14 +42,14 @@ export default class BridgeSettingsTab extends React.Component<IProps> {
         return <BridgeTile key={event.getId()} room={room} ev={event} />;
     }
 
-    static getBridgeStateEvents(roomId: string): MatrixEvent[] {
+    public static getBridgeStateEvents(roomId: string): MatrixEvent[] {
         const client = MatrixClientPeg.get();
         const roomState = client.getRoom(roomId).currentState;
 
         return BRIDGE_EVENT_TYPES.map((typeName) => roomState.getStateEvents(typeName)).flat(1);
     }
 
-    render() {
+    public render() {
         // This settings tab will only be invoked if the following function returns more
         // than 0 events, so no validation is needed at this stage.
         const bridgeEvents = BridgeSettingsTab.getBridgeStateEvents(this.props.roomId);

src/components/views/settings/tabs/room/GeneralRoomSettingsTab.tsx

@@ -37,9 +37,9 @@ interface IState {
 
 export default class GeneralRoomSettingsTab extends React.Component<IProps, IState> {
     public static contextType = MatrixClientContext;
-    context: ContextType<typeof MatrixClientContext>;
+    public context: ContextType<typeof MatrixClientContext>;
 
-    constructor(props: IProps, context: ContextType<typeof MatrixClientContext>) {
+    public constructor(props: IProps, context: ContextType<typeof MatrixClientContext>) {
         super(props, context);
 
         this.state = {

src/components/views/settings/tabs/room/NotificationSettingsTab.tsx

@@ -47,10 +47,10 @@ export default class NotificationsSettingsTab extends React.Component<IProps, IS
     private readonly roomProps: RoomEchoChamber;
     private soundUpload = createRef<HTMLInputElement>();
 
-    static contextType = MatrixClientContext;
+    public static contextType = MatrixClientContext;
     public context!: React.ContextType<typeof MatrixClientContext>;
 
-    constructor(props: IProps, context: React.ContextType<typeof MatrixClientContext>) {
+    public constructor(props: IProps, context: React.ContextType<typeof MatrixClientContext>) {
         super(props, context);
 
         this.roomProps = EchoChamber.forRoom(context.getRoom(this.props.roomId));

src/components/views/settings/tabs/room/RolesRoomSettingsTab.tsx

@@ -99,7 +99,7 @@ export class BannedUser extends React.Component<IBannedUserProps> {
             });
     };
 
-    render() {
+    public render() {
         let unbanButton;
 
         if (this.props.canUnban) {
@@ -132,11 +132,11 @@ interface IProps {
 }
 
 export default class RolesRoomSettingsTab extends React.Component<IProps> {
-    componentDidMount() {
+    public componentDidMount() {
         MatrixClientPeg.get().on(RoomStateEvent.Update, this.onRoomStateUpdate);
     }
 
-    componentWillUnmount() {
+    public componentWillUnmount() {
         const client = MatrixClientPeg.get();
         if (client) {
             client.removeListener(RoomStateEvent.Update, this.onRoomStateUpdate);
@@ -232,7 +232,7 @@ export default class RolesRoomSettingsTab extends React.Component<IProps> {
         });
     };
 
-    render() {
+    public render() {
         const client = MatrixClientPeg.get();
         const room = client.getRoom(this.props.roomId);
         const isSpaceRoom = room.isSpaceRoom();

src/components/views/settings/tabs/room/SecurityRoomSettingsTab.tsx

@@ -55,10 +55,10 @@ interface IState {
 }
 
 export default class SecurityRoomSettingsTab extends React.Component<IProps, IState> {
-    static contextType = MatrixClientContext;
+    public static contextType = MatrixClientContext;
     public context!: React.ContextType<typeof MatrixClientContext>;
 
-    constructor(props, context) {
+    public constructor(props, context) {
         super(props, context);
 
         const state = context.getRoom(this.props.roomId).currentState;
@@ -80,7 +80,7 @@ export default class SecurityRoomSettingsTab extends React.Component<IProps, ISt
         };
     }
 
-    componentDidMount() {
+    public componentDidMount() {
         this.context.on(RoomStateEvent.Events, this.onStateEvent);
         this.hasAliases().then((hasAliases) => this.setState({ hasAliases }));
     }
@@ -89,7 +89,7 @@ export default class SecurityRoomSettingsTab extends React.Component<IProps, ISt
         return event?.getContent()[key] || defaultValue;
     }
 
-    componentWillUnmount() {
+    public componentWillUnmount() {
         this.context.removeListener(RoomStateEvent.Events, this.onStateEvent);
     }
 
@@ -414,7 +414,7 @@ export default class SecurityRoomSettingsTab extends React.Component<IProps, ISt
         );
     }
 
-    render() {
+    public render() {
         const client = this.context;
         const room = client.getRoom(this.props.roomId);
         const isEncrypted = this.state.encrypted;

src/components/views/settings/tabs/user/AppearanceUserSettingsTab.tsx

@@ -50,7 +50,7 @@ export default class AppearanceUserSettingsTab extends React.Component<IProps, I
 
     private unmounted = false;
 
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {
@@ -64,7 +64,7 @@ export default class AppearanceUserSettingsTab extends React.Component<IProps, I
         };
     }
 
-    async componentDidMount() {
+    public async componentDidMount() {
         // Fetch the current user profile for the message preview
         const client = MatrixClientPeg.get();
         const userId = client.getUserId();
@@ -78,7 +78,7 @@ export default class AppearanceUserSettingsTab extends React.Component<IProps, I
         });
     }
 
-    componentWillUnmount() {
+    public componentWillUnmount() {
         this.unmounted = true;
     }
 
@@ -139,7 +139,7 @@ export default class AppearanceUserSettingsTab extends React.Component<IProps, I
         );
     }
 
-    render() {
+    public render() {
         const brand = SdkConfig.get().brand;
 
         return (

src/components/views/settings/tabs/user/GeneralUserSettingsTab.tsx

@@ -84,7 +84,7 @@ interface IState {
 export default class GeneralUserSettingsTab extends React.Component<IProps, IState> {
     private readonly dispatcherRef: string;
 
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {

src/components/views/settings/tabs/user/HelpUserSettingsTab.tsx

@@ -42,7 +42,7 @@ interface IState {
 }
 
 export default class HelpUserSettingsTab extends React.Component<IProps, IState> {
-    constructor(props) {
+    public constructor(props) {
         super(props);
 
         this.state = {
@@ -51,7 +51,7 @@ export default class HelpUserSettingsTab extends React.Component<IProps, IState>
         };
     }
 
-    componentDidMount(): void {
+    public componentDidMount(): void {
         PlatformPeg.get()
             .getAppVersion()
             .then((ver) => this.setState({ appVersion: ver }))
@@ -206,7 +206,7 @@ export default class HelpUserSettingsTab extends React.Component<IProps, IState>
         });
     };
 
-    render() {
+    public render() {
         const brand = SdkConfig.get().brand;
 
         let faqText = _t(

src/components/views/settings/tabs/user/LabsUserSettingsTab.tsx

@@ -33,7 +33,7 @@ interface IState {
 }
 
 export default class LabsUserSettingsTab extends React.Component<{}, IState> {
-    constructor(props: {}) {
+    public constructor(props: {}) {
         super(props);
 
         const cli = MatrixClientPeg.get();

src/components/views/settings/tabs/user/MjolnirUserSettingsTab.tsx

@@ -36,7 +36,7 @@ interface IState {
 }
 
 export default class MjolnirUserSettingsTab extends React.Component<{}, IState> {
-    constructor(props) {
+    public constructor(props) {
         super(props);
 
         this.state = {
@@ -246,7 +246,7 @@ export default class MjolnirUserSettingsTab extends React.Component<{}, IState>
         );
     }
 
-    render() {
+    public render() {
         const brand = SdkConfig.get().brand;
 
         return (

src/components/views/settings/tabs/user/NotificationUserSettingsTab.tsx

@@ -20,7 +20,7 @@ import { _t } from "../../../../../languageHandler";
 import Notifications from "../../Notifications";
 
 export default class NotificationUserSettingsTab extends React.Component {
-    render() {
+    public render() {
         return (
             <div className="mx_SettingsTab">
                 <div className="mx_SettingsTab_heading">{_t("Notifications")}</div>

src/components/views/settings/tabs/user/PreferencesUserSettingsTab.tsx

@@ -95,7 +95,7 @@ export default class PreferencesUserSettingsTab extends React.Component<IProps,
         // Autocomplete delay (niche text box)
     ];
 
-    constructor(props) {
+    public constructor(props) {
         super(props);
 
         this.state = {
@@ -151,7 +151,7 @@ export default class PreferencesUserSettingsTab extends React.Component<IProps,
         });
     };
 
-    render() {
+    public render() {
         const useCase = SettingsStore.getValue<UseCase | null>("FTUE.useCaseSelection");
         const roomListSettings = PreferencesUserSettingsTab.ROOM_LIST_SETTINGS
             // Only show the breadcrumbs setting if breadcrumbs v2 is disabled

src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx

@@ -87,7 +87,7 @@ interface IState {
 export default class SecurityUserSettingsTab extends React.Component<IProps, IState> {
     private dispatcherRef: string;
 
-    constructor(props: IProps) {
+    public constructor(props: IProps) {
         super(props);
 
         // Get rooms we're invited to

src/components/views/settings/tabs/user/VoiceUserSettingsTab.tsx

@@ -38,7 +38,7 @@ interface IState {
 }
 
 export default class VoiceUserSettingsTab extends React.Component<{}, IState> {
-    constructor(props: {}) {
+    public constructor(props: {}) {
         super(props);
 
         this.state = {
@@ -52,7 +52,7 @@ export default class VoiceUserSettingsTab extends React.Component<{}, IState> {
         };
     }
 
-    async componentDidMount() {
+    public async componentDidMount() {
         const canSeeDeviceLabels = await MediaDeviceHandler.hasAnyLabeledDevices();
         if (canSeeDeviceLabels) {
             this.refreshMediaDevices();
@@ -121,7 +121,7 @@ export default class VoiceUserSettingsTab extends React.Component<{}, IState> {
         );
     }
 
-    render() {
+    public render() {
         let requestButton = null;
         let speakerDropdown = null;
         let microphoneDropdown = null;