Fix edge case in context menu chevron positioning (#7899)

* Fix edge case in context menu chevron positioning

Signed-off-by: Robin Townsend <robin@robin.town>

* Expand context menu positioning regression tests

Signed-off-by: Robin Townsend <robin@robin.town>
This commit is contained in:
Robin 2022-02-25 12:49:57 -05:00 committed by GitHub
parent 3e4e7efd89
commit ece2b8572a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 93 additions and 18 deletions

View file

@ -271,7 +271,7 @@ export default class ContextMenu extends React.PureComponent<IProps, IState> {
windowHeight - contextMenuRect.height - WINDOW_PADDING,
);
if (chevronOffset.top !== undefined) {
chevronOffset.top = props.chevronOffset + props.bottom - position.bottom;
chevronOffset.top = props.chevronOffset + position.bottom - props.bottom;
}
}
if (position.left !== undefined) {
@ -288,7 +288,7 @@ export default class ContextMenu extends React.PureComponent<IProps, IState> {
windowWidth - contextMenuRect.width - WINDOW_PADDING,
);
if (chevronOffset.left !== undefined) {
chevronOffset.left = props.chevronOffset + props.right - position.right;
chevronOffset.left = props.chevronOffset + position.right - props.right;
}
}
}