imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use semantic headings in space preferences (#11021)

Browse source 
* remove mx_SettingsTab_heading style

* use semantic headings in space preferences dialog

* remove unused settings style: mx_SettingsTab_subheading
This commit is contained in:
Kerry 2023-06-01 09:22:03 +12:00 • committed by GitHub
parent 176daad49f
commit e9a8f4a11d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 31 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

10
res/css/views/dialogs/_SpacePreferencesDialog.pcss
View file

@ -31,16 +31,6 @@ limitations under the License.
.mx_SettingsTab {
min-width: unset;
.mx_SettingsTab_section {
font-size: $font-15px;
line-height: $font-24px;
.mx_Checkbox + p {
color: $secondary-content;
margin: 0 20px 0 24px;
}
}
}
}
}

6
res/css/views/dialogs/_SpaceSettingsDialog.pcss
View file

@ -37,12 +37,6 @@ limitations under the License.
margin-bottom: 20px;
}
& + .mx_SettingsTab_subheading {
border-top: 1px solid $menu-border-color;
margin-top: 0;
padding-top: 24px;
}
.mx_StyledRadioButton {
margin-top: 8px;
margin-bottom: 4px;

24
res/css/views/settings/tabs/_SettingsTab.pcss
View file

@ -15,7 +15,6 @@ limitations under the License.
*/
.mx_SettingsTab {
--SettingsTab_heading_nth_child-margin-top: 30px; /* TODO: Use a spacing variable */
--SettingsTab_tooltip-max-width: 120px; /* So it fits in the space provided by the page */
color: $primary-content;
@ -47,29 +46,6 @@ limitations under the License.
color: $alert;
}
.mx_SettingsTab_heading {
font-size: $font-20px;
font-weight: var(--font-semi-bold);
color: $primary-content;
margin-top: 10px; /* TODO: Use a spacing variable */
margin-bottom: 10px; /* TODO: Use a spacing variable */
margin-right: 100px; /* TODO: Use a spacing variable */
&:nth-child(n + 2) {
margin-top: var(--SettingsTab_heading_nth_child-margin-top);
}
}
.mx_SettingsTab_subheading {
font-size: $font-16px;
display: block;
font-weight: var(--font-semi-bold);
color: $primary-content;
margin-top: $spacing-12;
margin-bottom: 10px; /* TODO: Use a spacing variable */
margin-right: 100px; /* TODO: Use a spacing variable */
}
.mx_SettingsTab_subsectionText {
color: $secondary-content;
font-size: $font-14px;