imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix corrupt thread timeline for sending events (#11260)

Browse source 
Events which are still in the process of being sent should *not* be included
in the `EventTimeline`. Doing so means that we will attempt to render them
twice, which makes react explode.

Fixes https://github.com/vector-im/element-web/issues/25770
This commit is contained in:
Richard van der Hoff 2023-07-14 11:59:55 +01:00 • committed by GitHub
parent cb592dc709
commit e959eca354
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/components/structures/ThreadView.tsx
View file

@ -214,7 +214,12 @@ export default class ThreadView extends React.Component<IProps, IState> {
let thread = this.props.room.getThread(eventId);
if (!thread) {
thread = this.props.room.createThread(eventId, mxEv, [mxEv], true);
const events = [];
// if the event is still being sent, don't include it in the Thread yet - otherwise the timeline panel
// will attempt to show it twice (once as a regular event, once as a pending event) and everything will
// blow up
if (mxEv.status === null) events.push(mxEv);
thread = this.props.room.createThread(eventId, mxEv, events, true);
}
this.updateThread(thread);