Use h1 as first heading in dialogs (#12250)
* Use h1 as first heading in dialogs The dialog should be modal and therefore the only content active on the screen, so the title of the dialog should be the top level. Update snapshots & tests appropriately. * Just customise the letter spacing on dialog titles
This commit is contained in:
parent
b5048bf63e
commit
e8ce9cb360
21 changed files with 71 additions and 70 deletions
|
@ -43,7 +43,7 @@ test.describe("User Onboarding (new user)", () => {
|
|||
test("app download dialog", async ({ page }) => {
|
||||
await page.getByRole("button", { name: "Download apps" }).click();
|
||||
await expect(
|
||||
page.getByRole("dialog").getByRole("heading", { level: 2, name: "Download Element" }),
|
||||
page.getByRole("dialog").getByRole("heading", { level: 1, name: "Download Element" }),
|
||||
).toBeVisible();
|
||||
await expect(page.locator(".mx_Dialog")).toMatchScreenshot();
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue