imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix highlights not being applied to plaintext messages (#9126)

Browse source 
* Fix highlights not being applied to plaintext messages

* Add percy test for search result highlighting

* Fix percy target

* Update timeline.spec.ts
This commit is contained in:
Michael Telatynski 2022-08-05 08:08:56 +01:00 • committed by GitHub
parent a866005bea
commit e864dbfacf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 41 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

16
cypress/e2e/timeline/timeline.spec.ts
View file

@ -57,12 +57,12 @@ const expectAvatar = (e: JQuery<HTMLElement>, avatarUrl: string): void => {
});
};
const sendEvent = (roomId: string): Chainable<ISendEventResponse> => {
const sendEvent = (roomId: string, html = false): Chainable<ISendEventResponse> => {
return cy.sendEvent(
roomId,
null,
"m.room.message" as EventType,
MessageEvent.from("Message").serialize().content,
MessageEvent.from("Message", html ? "<b>Message</b>" : undefined).serialize().content,
);
};
@ -261,6 +261,18 @@ describe("Timeline", () => {
// Make sure "collapse" link button worked
cy.get(".mx_GenericEventListSummary_toggle[aria-expanded=false]");
});
it("should highlight search result words regardless of formatting", () => {
sendEvent(roomId);
sendEvent(roomId, true);
cy.visit("/#/room/" + roomId);
cy.get(".mx_RoomHeader_searchButton").click();
cy.get(".mx_SearchBar_input input").type("Message{enter}");
cy.get(".mx_EventTile:not(.mx_EventTile_contextual)").find(".mx_EventTile_searchHighlight").should("exist");
cy.get(".mx_RoomView_searchResultsPanel").percySnapshotElement("Highlighted search results");
});
});
describe("message sending", () => {