imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add logging for a bunch of silently swallowed errors (#7148)

Browse source
This commit is contained in:
James Salter 2021-11-18 09:01:45 +11:00 • committed by GitHub
parent 8b6778e1d3
commit e549438e2a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/BasePlatform.ts
View file

@ -317,7 +317,9 @@ export default abstract class BasePlatform {
let data;
try {
data = await idbLoad("pickleKey", [userId, deviceId]);
} catch (e) {}
} catch (e) {
logger.error("idbLoad for pickleKey failed", e);
}
if (!data) {
return null;
}
@ -396,6 +398,8 @@ export default abstract class BasePlatform {
async destroyPickleKey(userId: string, deviceId: string): Promise<void> {
try {
await idbDelete("pickleKey", [userId, deviceId]);
} catch (e) {}
} catch (e) {
logger.error("idbDelete failed in destroyPickleKey", e);
}
}
}

12
src/Lifecycle.ts
View file

@ -324,7 +324,9 @@ export async function getStoredSessionVars(): Promise<IStoredSession> {
let accessToken;
try {
accessToken = await StorageManager.idbLoad("account", "mx_access_token");
} catch (e) {}
} catch (e) {
logger.error("StorageManager.idbLoad failed for account:mx_access_token", e);
}
if (!accessToken) {
accessToken = localStorage.getItem("mx_access_token");
if (accessToken) {
@ -332,7 +334,9 @@ export async function getStoredSessionVars(): Promise<IStoredSession> {
// try to migrate access token to IndexedDB if we can
await StorageManager.idbSave("account", "mx_access_token", accessToken);
localStorage.removeItem("mx_access_token");
} catch (e) {}
} catch (e) {
logger.error("migration of access token to IndexedDB failed", e);
}
}
}
// if we pre-date storing "mx_has_access_token", but we retrieved an access
@ -858,7 +862,9 @@ async function clearStorage(opts?: { deleteEverything?: boolean }): Promise<void
try {
await StorageManager.idbDelete("account", "mx_access_token");
} catch (e) {}
} catch (e) {
logger.error("idbDelete failed for account:mx_access_token", e);
}
// now restore those invites
if (!opts?.deleteEverything) {