imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't specify sample rates for voice messages

Browse source 
Turns out the browser doesn't actually resample for us, instead opting to explode in sadness.

We'll leave the resampling to the opus encoder.

Fixes https://github.com/vector-im/element-web/issues/16775
This commit is contained in:
Travis Ralston 2021-03-25 18:24:58 -06:00
parent 75bfaa58bb
commit e31ad0e174
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/voice/VoiceRecorder.ts
View file

@ -51,9 +51,6 @@ export class VoiceRecorder {
private async makeRecorder() { private async makeRecorder() {
this.recorderStream = await navigator.mediaDevices.getUserMedia({ this.recorderStream = await navigator.mediaDevices.getUserMedia({
audio: { audio: {
// specify some audio settings so we're feeding the recorder with the
// best possible values. The browser will handle resampling for us.
sampleRate: SAMPLE_RATE,
channelCount: CHANNELS, channelCount: CHANNELS,
noiseSuppression: true, // browsers ignore constraints they can't honour noiseSuppression: true, // browsers ignore constraints they can't honour
deviceId: CallMediaHandler.getAudioInput(), deviceId: CallMediaHandler.getAudioInput(),
@ -61,7 +58,6 @@ export class VoiceRecorder {
}); });
this.recorderContext = new AudioContext({ this.recorderContext = new AudioContext({
latencyHint: "interactive", latencyHint: "interactive",
sampleRate: SAMPLE_RATE, // once again, the browser will resample for us
}); });
this.recorderSource = this.recorderContext.createMediaStreamSource(this.recorderStream); this.recorderSource = this.recorderContext.createMediaStreamSource(this.recorderStream);
this.recorderFreqNode = this.recorderContext.createAnalyser(); this.recorderFreqNode = this.recorderContext.createAnalyser();