imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve stability of Playwright screenshot tests (#11983)

Browse source
This commit is contained in:
Michael Telatynski 2023-12-04 11:02:48 +00:00 • committed by GitHub
parent 74ea0d134e
commit e180ca841b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
23 changed files with 71 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

8
playwright/e2e/settings/appearance-user-settings-tab.spec.ts
View file

@ -33,9 +33,7 @@ test.describe("Appearance user settings tab", () => {
// Assert that "Hide advanced" link button is rendered
await expect(tab.getByRole("button", { name: "Hide advanced" })).toBeVisible();
await expect(tab).toHaveScreenshot("appearance-tab.png", {
mask: [tab.locator(".mx_DisambiguatedProfile_displayName, .mx_BaseAvatar")],
});
await expect(tab).toMatchScreenshot("appearance-tab.png");
});
test("should support switching layouts", async ({ page, user, app }) => {
@ -94,7 +92,7 @@ test.describe("Appearance user settings tab", () => {
fontSliderSection.locator("output .mx_Slider_selection_label", { hasText: String(MIN_FONT_SIZE) }),
).toBeVisible();
await expect(fontSliderSection).toHaveScreenshot(`font-slider-${MIN_FONT_SIZE}.png`);
await expect(fontSliderSection).toMatchScreenshot(`font-slider-${MIN_FONT_SIZE}.png`);
// Click the right position of the slider
await slider.click({ position: { x: 572, y: 10 } });
@ -106,7 +104,7 @@ test.describe("Appearance user settings tab", () => {
fontSliderSection.locator("output .mx_Slider_selection_label", { hasText: String(MAX_FONT_SIZE) }),
).toBeVisible();
await expect(fontSliderSection).toHaveScreenshot(`font-slider-${MAX_FONT_SIZE}.png`);
await expect(fontSliderSection).toMatchScreenshot(`font-slider-${MAX_FONT_SIZE}.png`);
});
test("should disable font size slider when custom font size is used", async ({ page, app, user }) => {

2
playwright/e2e/settings/general-room-settings-tab.spec.ts
View file

@ -34,7 +34,7 @@ test.describe("General room settings tab", () => {
// Assert that "Show less" details element is rendered
await expect(settings.getByText("Show less")).toBeVisible();
await expect(settings).toHaveScreenshot();
await expect(settings).toMatchScreenshot();
// Click the "Show less" details element
await settings.getByText("Show less").click();

2
playwright/e2e/settings/general-user-settings-tab.spec.ts
View file

@ -35,7 +35,7 @@ test.describe("General user settings tab", () => {
});
test("should be rendered properly", async ({ uut }) => {
await expect(uut).toHaveScreenshot("general.png", {
await expect(uut).toMatchScreenshot("general.png", {
// Exclude userId from snapshots
mask: [uut.locator(".mx_ProfileSettings_profile_controls > p")],
});

2
playwright/e2e/settings/preferences-user-settings-tab.spec.ts
View file

@ -26,6 +26,6 @@ test.describe("Preferences user settings tab", () => {
// Assert that the top heading is rendered
await expect(tab.getByRole("heading", { name: "Preferences" })).toBeVisible();
await expect(tab).toHaveScreenshot();
await expect(tab).toMatchScreenshot();
});
});

2
playwright/e2e/settings/security-user-settings-tab.spec.ts
View file

@ -44,7 +44,7 @@ test.describe("Security user settings tab", () => {
test("should be rendered properly", async ({ app, page }) => {
const tab = await app.settings.openUserSettings("Security");
await tab.getByRole("button", { name: "Learn more" }).click();
await expect(page.locator(".mx_AnalyticsLearnMoreDialog_wrapper .mx_Dialog")).toHaveScreenshot();
await expect(page.locator(".mx_AnalyticsLearnMoreDialog_wrapper .mx_Dialog")).toMatchScreenshot();
});
});
});