imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make room model mandatory on the RoomHeader (#11355)

Browse source 
* Remove oobData from RoomHeader

It is never used as the RoomHeader is not shown unless a Room model exists

* Make room model mandatory on the RoomHeader
This commit is contained in:
Germain 2023-08-02 16:29:19 +01:00 • committed by GitHub
parent 40442508de
commit d94808a197
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 76 deletions
Download patch file Download diff file Expand all files Collapse all files

17
test/components/views/rooms/RoomHeader-test.tsx
View file

@ -46,28 +46,11 @@ describe("Roomeader", () => {
setCardSpy = jest.spyOn(RightPanelStore.instance, "setCard");
});
it("renders with no props", () => {
const { asFragment } = render(<RoomHeader />);
expect(asFragment()).toMatchSnapshot();
});
it("renders the room header", () => {
const { container } = render(<RoomHeader room={room} />);
expect(container).toHaveTextContent(ROOM_ID);
});
it("display the out-of-band room name", () => {
const OOB_NAME = "My private room";
const { container } = render(
<RoomHeader
oobData={{
name: OOB_NAME,
}}
/>,
);
expect(container).toHaveTextContent(OOB_NAME);
});
it("renders the room topic", async () => {
const TOPIC = "Hello World!";

44
test/components/views/rooms/__snapshots__/RoomHeader-test.tsx.snap
View file

@ -1,44 +0,0 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`Roomeader renders with no props 1`] = `
<DocumentFragment>
<header
class="mx_RoomHeader light-panel"
>
<span
class="mx_BaseAvatar"
role="presentation"
>
<span
aria-hidden="true"
class="mx_BaseAvatar_initial"
style="font-size: 26px; width: 40px; line-height: 40px;"
>
?
</span>
<img
alt=""
aria-hidden="true"
class="mx_BaseAvatar_image"
data-testid="avatar-img"
loading="lazy"
src="data:image/png;base64,00"
style="width: 40px; height: 40px;"
/>
</span>
<div
class="mx_RoomHeader_info"
>
<div
aria-level="1"
dir="auto"
role="heading"
style="font: var(--cpd-font-body-lg-semibold); letter-spacing: var(--cpd-font-letter-spacing-body-lg);"
title="Join Room"
>
Join Room
</div>
</div>
</header>
</DocumentFragment>
`;