imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unused sessionStorage layer (#8834)

Browse source 
* Remove unused sessionStorage layer

* Update global.d.ts

* Fix tests
This commit is contained in:
Michael Telatynski 2022-06-14 21:29:24 +01:00 • committed by GitHub
parent 7da8c51c6b
commit d81e2cea14
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 21 additions and 78 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cypress/global.d.ts vendored
View file

@ -26,7 +26,6 @@ import type {
Visibility,
RoomMemberEvent,
} from "matrix-js-sdk/src/matrix";
import type { WebStorageSessionStore } from "matrix-js-sdk/src/store/session/webstorage";
import type { MatrixDispatcher } from "../src/dispatcher/dispatcher";
import type PerformanceMonitor from "../src/performance";
@ -49,7 +48,6 @@ declare global {
MatrixScheduler: typeof MatrixScheduler;
MemoryStore: typeof MemoryStore;
MemoryCryptoStore: typeof MemoryCryptoStore;
WebStorageSessionStore: typeof WebStorageSessionStore;
Visibility: typeof Visibility;
Preset: typeof Preset;
};

2
cypress/support/bot.ts
View file

@ -20,7 +20,6 @@ import request from "browser-request";
import type { MatrixClient } from "matrix-js-sdk/src/client";
import { SynapseInstance } from "../plugins/synapsedocker";
import { MockStorage } from "./storage";
import Chainable = Cypress.Chainable;
declare global {
@ -51,7 +50,6 @@ Cypress.Commands.add("getBot", (synapse: SynapseInstance, displayName?: string):
store: new win.matrixcs.MemoryStore(),
scheduler: new win.matrixcs.MatrixScheduler(),
cryptoStore: new win.matrixcs.MemoryCryptoStore(),
sessionStore: new win.matrixcs.WebStorageSessionStore(new MockStorage()),
});
cli.on(win.matrixcs.RoomMemberEvent.Membership, (event, member) => {

58
cypress/support/storage.ts
View file

@ -1,58 +0,0 @@
/*
Copyright 2022 The Matrix.org Foundation C.I.C.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
export class MockStorage implements Storage {
private data: Record<string, string> = {};
private keys: string[] = [];
public length = 0;
constructor() {}
public setItem(k: string, v: string) {
this.data[k] = v;
this.recalc();
}
public getItem(k: string): string | null {
return this.data[k] || null;
}
public removeItem(k: string) {
delete this.data[k];
this.recalc();
}
public clear() {
this.data = {};
this.recalc();
}
public key(index: number): string {
return this.keys[index];
}
private recalc() {
const keys = [];
for (const k in this.data) {
if (!this.data.hasOwnProperty(k)) {
continue;
}
keys.push(k);
}
this.keys = keys;
this.length = keys.length;
}
}