imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Apply PR feedback, don't change room to go to its settings

Browse source 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski 2019-02-25 23:08:51 +00:00
parent 393fd26a42
commit d4b6ce6932
4 changed files with 22 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/components/views/context_menus/RoomTileContextMenu.js
View file

@ -273,10 +273,9 @@ module.exports = React.createClass({
_onClickSettings: function() {
dis.dispatch({
action: 'view_room',
action: 'open_room_settings',
room_id: this.props.room.roomId,
}, true);
dis.dispatch({ action: 'open_room_settings' });
});
if (this.props.onFinished) {
this.props.onFinished();
}
@ -373,8 +372,9 @@ module.exports = React.createClass({
// Can't set notif level or tags on non-join rooms
if (myMembership !== 'join') {
return <div>
{ this._renderSettingsMenu() }
{ this._renderLeaveMenu(myMembership) }
<hr className="mx_RoomTileContextMenu_separator" />
{ this._renderSettingsMenu() }
</div>;
}
@ -382,10 +382,11 @@ module.exports = React.createClass({
<div>
{ this._renderNotifMenu() }
<hr className="mx_RoomTileContextMenu_separator" />
{ this._renderSettingsMenu() }
{ this._renderLeaveMenu(myMembership) }
<hr className="mx_RoomTileContextMenu_separator" />
{ this._renderRoomTagMenu() }
<hr className="mx_RoomTileContextMenu_separator" />
{ this._renderSettingsMenu() }
</div>
);
},