imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove TODO comments about spacing variables (#10695)

Browse source 
The variables on _spacing.pcss have been deprecated by https://github.com/matrix-org/matrix-react-sdk/pull/10686
This commit is contained in:
Suguru Hirahara 2023-06-06 14:03:52 +00:00 • committed by GitHub
parent c42a7769e9
commit d340fa8d2a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
18 changed files with 56 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

14
res/css/views/right_panel/_BaseCard.pcss
View file

@ -17,7 +17,7 @@ limitations under the License.
.mx_BaseCard {
--BaseCard_padding-inline: $spacing-8;
--BaseCard_EventTile_line-padding-block: 2px;
--BaseCard_EventTile-spacing-inline: 36px; /* TODO: Use a spacing variable */
--BaseCard_EventTile-spacing-inline: 36px;
--BaseCard_header-button-size: 24px;
padding: 0 var(--BaseCard_padding-inline);
@ -32,7 +32,7 @@ limitations under the License.
margin: $spacing-4 0 $spacing-12;
> h2 {
margin: 0 44px; /* TODO: Use a spacing variable */
margin: 0 44px;
font-size: $font-18px;
font-weight: var(--font-semi-bold);
overflow: hidden;
@ -79,7 +79,7 @@ limitations under the License.
margin-inline-start: var(--BaseCard_header-button-size);
.mx_BaseCard_header_title_heading {
margin-inline-start: 6px; /* TODO: Use a spacing variable */
margin-inline-start: 6px;
}
}
}
@ -159,7 +159,7 @@ limitations under the License.
}
.mx_BaseCard_Button {
padding: 10px; /* TODO: Use a spacing variable */
padding: 10px;
padding-inline-start: $spacing-12;
margin: 0;
position: relative;
@ -234,8 +234,8 @@ limitations under the License.
font-size: $font-12px;
color: $secondary-content;
padding-top: 10px; /* TODO: Use a spacing variable */
padding-bottom: 10px; /* TODO: Use a spacing variable */
padding-top: 10px;
padding-bottom: 10px;
border: 1px solid $quinary-content;
box-shadow: 0px 1px 3px rgba(23, 25, 28, 0.05);
@ -243,7 +243,7 @@ limitations under the License.
.mx_ContextualMenu_chevron_top {
left: auto;
right: 22px; /* TODO: Use a spacing variable */
right: 22px;
border-bottom-color: $quinary-content;
&::after {

2
res/css/views/right_panel/_ThreadPanel.pcss
View file

@ -26,7 +26,7 @@ limitations under the License.
}
.mx_ThreadPanel_dropdown {
padding: 3px $spacing-4 3px $spacing-8; /* TODO: Use a spacing variable */
padding: 3px $spacing-4 3px $spacing-8;
border-radius: 4px;
line-height: 1.5;
user-select: none;

10
res/css/views/right_panel/_UserInfo.pcss
View file

@ -27,7 +27,7 @@ limitations under the License.
top: 0;
border-radius: 4px;
background-color: $dark-panel-bg-color;
margin: 9px; /* TODO: Use a variable */
margin: 9px;
z-index: 1; /* render on top of the right panel */
div {
@ -44,7 +44,7 @@ limitations under the License.
h2 {
font-size: $font-18px;
font-weight: var(--font-semi-bold);
margin: 18px 0 0 0; /* TODO: Use a variable */
margin: 18px 0 0 0;
}
.mx_UserInfo_container {
@ -151,7 +151,7 @@ limitations under the License.
}
p {
margin: 5px 0; /* TODO: Use a variable */
margin: 5px 0;
}
.mx_UserInfo_profile {
@ -179,7 +179,7 @@ limitations under the License.
}
.mx_E2EIcon {
margin-top: 3px; /* visual vertical centering to the top line of text. TODO: Use a variable */
margin-top: 3px; /* visual vertical centering to the top line of text. */
margin-inline-end: $spacing-4; /* margin from displayName */
min-width: 18px; /* convince flexbox to not collapse it */
}
@ -196,7 +196,7 @@ limitations under the License.
justify-content: center;
align-items: center;
margin: 6px 0; /* TODO: Use a variable */
margin: 6px 0;
.mx_UserInfo_roleDescription {
display: flex;