Enable strictPropertyInitialization (#11203)

src/components/views/settings/CrossSigningPanel.tsx

@@ -31,7 +31,7 @@ import AccessibleButton from "../elements/AccessibleButton";
 import { SettingsSubsectionText } from "./shared/SettingsSubsection";
 
 interface IState {
-    error?: Error;
+    error: boolean;
     crossSigningPublicKeysOnDevice?: boolean;
     crossSigningPrivateKeysInStorage?: boolean;
     masterPrivateKeyCached?: boolean;
@@ -47,7 +47,9 @@ export default class CrossSigningPanel extends React.PureComponent<{}, IState> {
     public constructor(props: {}) {
         super(props);
 
-        this.state = {};
+        this.state = {
+            error: false,
+        };
     }
 
     public componentDidMount(): void {
@@ -125,7 +127,7 @@ export default class CrossSigningPanel extends React.PureComponent<{}, IState> {
      * @param {bool} [forceReset] Bootstrap again even if keys already present
      */
     private bootstrapCrossSigning = async ({ forceReset = false }): Promise<void> => {
-        this.setState({ error: undefined });
+        this.setState({ error: false });
         try {
             const cli = MatrixClientPeg.safeGet();
             await cli.bootstrapCrossSigning({
@@ -143,7 +145,7 @@ export default class CrossSigningPanel extends React.PureComponent<{}, IState> {
                 setupNewCrossSigning: forceReset,
             });
         } catch (e) {
-            this.setState({ error: e });
+            this.setState({ error: true });
             logger.error("Error bootstrapping cross-signing", e);
         }
         if (this.unmounted) return;

src/components/views/settings/EventIndexPanel.tsx

@@ -239,7 +239,11 @@ export default class EventIndexPanel extends React.Component<{}, IState> {
                         <SettingsSubsectionText>
                             <details>
                                 <summary>{_t("Advanced")}</summary>
-                                <code>{EventIndexPeg.error.message}</code>
+                                <code>
+                                    {EventIndexPeg.error instanceof Error
+                                        ? EventIndexPeg.error.message
+                                        : _t("Unknown error")}
+                                </code>
                                 <p>
                                     <AccessibleButton key="delete" kind="danger" onClick={this.confirmEventStoreReset}>
                                         {_t("Reset")}

src/components/views/settings/JoinRuleSettings.tsx

@@ -40,7 +40,7 @@ export interface JoinRuleSettingsProps {
     room: Room;
     promptUpgrade?: boolean;
     closeSettingsFn(): void;
-    onError(error: Error): void;
+    onError(error: unknown): void;
     beforeChange?(joinRule: JoinRule): Promise<boolean>; // if returns false then aborts the change
     aliasWarning?: ReactNode;
 }

src/components/views/settings/SecureBackupPanel.tsx

@@ -35,7 +35,7 @@ import { SettingsSubsectionText } from "./shared/SettingsSubsection";
 
 interface IState {
     loading: boolean;
-    error: Error | null;
+    error: boolean;
     backupKeyStored: boolean | null;
     backupKeyCached: boolean | null;
     backupKeyWellFormed: boolean | null;
@@ -54,7 +54,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
 
         this.state = {
             loading: true,
-            error: null,
+            error: false,
             backupKeyStored: null,
             backupKeyCached: null,
             backupKeyWellFormed: null,
@@ -103,7 +103,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
             const keyBackupResult = await MatrixClientPeg.safeGet().checkKeyBackup();
             this.setState({
                 loading: false,
-                error: null,
+                error: false,
                 backupInfo: keyBackupResult?.backupInfo ?? null,
                 backupSigStatus: keyBackupResult?.trustInfo ?? null,
             });
@@ -112,7 +112,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
             if (this.unmounted) return;
             this.setState({
                 loading: false,
-                error: e,
+                error: true,
                 backupInfo: null,
                 backupSigStatus: null,
             });
@@ -128,7 +128,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
             if (this.unmounted) return;
             this.setState({
                 loading: false,
-                error: null,
+                error: false,
                 backupInfo,
                 backupSigStatus,
             });
@@ -137,7 +137,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
             if (this.unmounted) return;
             this.setState({
                 loading: false,
-                error: e,
+                error: true,
                 backupInfo: null,
                 backupSigStatus: null,
             });
@@ -209,13 +209,13 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
     };
 
     private resetSecretStorage = async (): Promise<void> => {
-        this.setState({ error: null });
+        this.setState({ error: false });
         try {
             await accessSecretStorage(async (): Promise<void> => {}, /* forceReset = */ true);
         } catch (e) {
             logger.error("Error resetting secret storage", e);
             if (this.unmounted) return;
-            this.setState({ error: e });
+            this.setState({ error: true });
         }
         if (this.unmounted) return;
         this.loadBackupStatus();