imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iterate PR

Browse source
This commit is contained in:
Michael Telatynski 2021-06-16 09:23:06 +01:00
parent a63d9220d2
commit cee294f5a7
6 changed files with 34 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/utils/arrays.ts
View file

@ -230,7 +230,7 @@ export function arrayMerge<T>(...a: T[][]): T[] {
* @param toIndex the index of where to put the element.
* @returns A new array with the requested value moved.
*/
export function reorder<T>(list: T[], fromIndex: number, toIndex: number): T[] {
export function moveElement<T>(list: T[], fromIndex: number, toIndex: number): T[] {
const result = Array.from(list);
const [removed] = result.splice(fromIndex, 1);
result.splice(toIndex, 0, removed);

4
src/utils/stringOrderField.ts
View file

@ -16,7 +16,7 @@ limitations under the License.
import { alphabetPad, baseToString, stringToBase, DEFAULT_ALPHABET } from "matrix-js-sdk/src/utils";
import { reorder } from "./arrays";
import { moveElement } from "./arrays";
export const midPointsBetweenStrings = (
a: string,
@ -73,7 +73,7 @@ export const reorderLexicographically = (
// zip orders with their indices to simplify later index wrangling
const ordersWithIndices: IEntry[] = orders.map((order, index) => ({ index, order }));
// apply the fundamental order update to the zipped array
const newOrder = reorder(ordersWithIndices, fromIndex, toIndex);
const newOrder = moveElement(ordersWithIndices, fromIndex, toIndex);
// check if we have to fill undefined orders to complete placement
const orderToLeftUndefined = newOrder[toIndex - 1]?.order === undefined;