imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add eslint rule unicorn/no-instanceof-array (#9527)

Browse source
This commit is contained in:
Michael Telatynski 2022-11-02 14:54:28 +00:00 • committed by GitHub
parent f05cc5d8f3
commit c79f45e5e6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 69 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/utils/DirectoryUtils.ts
View file

@ -26,7 +26,7 @@ export type Protocols = Record<string, IProtocol>;
export function instanceForInstanceId(protocols: Protocols, instanceId: string | null | undefined): IInstance | null {
if (!instanceId) return null;
for (const proto of Object.keys(protocols)) {
if (!protocols[proto].instances && protocols[proto].instances instanceof Array) continue;
if (!Array.isArray(protocols[proto].instances)) continue;
for (const instance of protocols[proto].instances) {
if (instance.instance_id == instanceId) return instance;
}
@ -39,7 +39,7 @@ export function instanceForInstanceId(protocols: Protocols, instanceId: string |
export function protocolNameForInstanceId(protocols: Protocols, instanceId: string | null | undefined): string | null {
if (!instanceId) return null;
for (const proto of Object.keys(protocols)) {
if (!protocols[proto].instances && protocols[proto].instances instanceof Array) continue;
if (!Array.isArray(protocols[proto].instances)) continue;
for (const instance of protocols[proto].instances) {
if (instance.instance_id == instanceId) return proto;
}