imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Set our own booleans instead of using isMounted

Browse source
This commit is contained in:
Richard van der Hoff 2016-01-11 11:38:04 +00:00
parent 62cf34b58c
commit c30aeac315
2 changed files with 19 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/components/structures/ScrollPanel.js
View file

@ -112,6 +112,14 @@ module.exports = React.createClass({
this.checkFillState();
},
componentWillUnmount: function() {
// set a boolean to say we've been unmounted, which any pending
// promises can use to throw away their results.
//
// (We could use isMounted(), but facebook have deprecated that.)
this.unmounted = true;
},
onScroll: function(ev) {
var sn = this._getScrollNode();
debuglog("Scroll event: offset now:", sn.scrollTop, "recentEventScroll:", this.recentEventScroll);
@ -158,7 +166,7 @@ module.exports = React.createClass({
// check the scroll state and send out backfill requests if necessary.
checkFillState: function() {
if (!this.isMounted()) {
if (this.unmounted) {
return;
}
@ -350,7 +358,7 @@ module.exports = React.createClass({
* message panel.
*/
_getScrollNode: function() {
if (!this.isMounted()) {
if (this.unmounted) {
// this shouldn't happen, but when it does, turn the NPE into
// something more meaningful.
throw new Error("ScrollPanel._getScrollNode called when unmounted");