imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prefer RoomStateEvent.Update where possible as it fires far less (#7878)

Browse source
This commit is contained in:
Michael Telatynski 2022-02-24 14:39:25 +00:00 • committed by GitHub
parent 36ae0ea49d
commit c257bc3f7a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
40 changed files with 223 additions and 190 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/components/views/settings/ChangeAvatar.tsx
View file

@ -18,6 +18,7 @@ import React from 'react';
import { MatrixEvent } from 'matrix-js-sdk/src/models/event';
import { Room } from 'matrix-js-sdk/src/models/room';
import { RoomStateEvent } from "matrix-js-sdk/src/models/room-state";
import { EventType } from "matrix-js-sdk/src/@types/event";
import { MatrixClientPeg } from "../../../MatrixClientPeg";
import { _t } from '../../../languageHandler';
@ -96,8 +97,10 @@ export default class ChangeAvatar extends React.Component<IProps, IState> {
return;
}
if (ev.getRoomId() !== this.props.room.roomId || ev.getType() !== 'm.room.avatar'
|| ev.getSender() !== MatrixClientPeg.get().getUserId()) {
if (ev.getRoomId() !== this.props.room.roomId ||
ev.getType() !== EventType.RoomAvatar ||
ev.getSender() !== MatrixClientPeg.get().getUserId()
) {
return;
}

7
src/components/views/settings/tabs/room/RolesRoomSettingsTab.tsx
View file

@ -17,7 +17,6 @@ limitations under the License.
import React from 'react';
import { EventType } from "matrix-js-sdk/src/@types/event";
import { RoomMember } from "matrix-js-sdk/src/models/room-member";
import { MatrixEvent } from "matrix-js-sdk/src/models/event";
import { RoomState, RoomStateEvent } from "matrix-js-sdk/src/models/room-state";
import { logger } from "matrix-js-sdk/src/logger";
import { throttle } from "lodash";
@ -123,17 +122,17 @@ interface IProps {
@replaceableComponent("views.settings.tabs.room.RolesRoomSettingsTab")
export default class RolesRoomSettingsTab extends React.Component<IProps> {
componentDidMount() {
MatrixClientPeg.get().on(RoomStateEvent.Members, this.onRoomMembership);
MatrixClientPeg.get().on(RoomStateEvent.Update, this.onRoomStateUpdate);
}
componentWillUnmount() {
const client = MatrixClientPeg.get();
if (client) {
client.removeListener(RoomStateEvent.Members, this.onRoomMembership);
client.removeListener(RoomStateEvent.Update, this.onRoomStateUpdate);
}
}
private onRoomMembership = (event: MatrixEvent, state: RoomState, member: RoomMember) => {
private onRoomStateUpdate = (state: RoomState) => {
if (state.roomId !== this.props.roomId) return;
this.onThisRoomMembership();
};