imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid rendering view-message link in RoomKnocksBar unnecessarily (#11598)

Browse source 
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
This commit is contained in:
Charly Nguyen 2023-09-11 15:33:27 +02:00 • committed by GitHub
parent 3c6d8a2a28
commit bb91df1d3c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/components/views/rooms/RoomKnocksBar.tsx
View file

@ -112,7 +112,7 @@ export const RoomKnocksBar: VFC<{ room: Room }> = ({ room }) => {
</> </>
); );
names = `${knockMembers[0].name} (${knockMembers[0].userId})`; names = `${knockMembers[0].name} (${knockMembers[0].userId})`;
link = ( link = knockMembers[0].events.member?.getContent().reason && (
<AccessibleButton <AccessibleButton
className="mx_RoomKnocksBar_link" className="mx_RoomKnocksBar_link"
element="a" element="a"

29
test/components/views/rooms/RoomKnocksBar-test.tsx
View file

@ -165,13 +165,28 @@ describe("RoomKnocksBar", () => {
expect(screen.getByRole("paragraph")).toHaveTextContent(`${bob.name} (${bob.userId})`); expect(screen.getByRole("paragraph")).toHaveTextContent(`${bob.name} (${bob.userId})`);
}); });
it("renders a link to open the room settings people tab", () => { describe("when a knock reason is not provided", () => {
getComponent(room); it("does not render a link to open the room settings people tab", () => {
fireEvent.click(getButton("View message")); getComponent(room);
expect(dis.dispatch).toHaveBeenCalledWith({ expect(screen.queryByRole("button", { name: "View message" })).not.toBeInTheDocument();
action: "open_room_settings", });
initial_tab_id: RoomSettingsTab.People, });
room_id: roomId,
describe("when a knock reason is provided", () => {
it("renders a link to open the room settings people tab", () => {
bob.setMembershipEvent(
new MatrixEvent({
content: { displayname: "Bob", membership: "knock", reason: "some reason" },
type: EventType.RoomMember,
}),
);
getComponent(room);
fireEvent.click(getButton("View message"));
expect(dis.dispatch).toHaveBeenCalledWith({
action: "open_room_settings",
initial_tab_id: RoomSettingsTab.People,
room_id: roomId,
});
}); });
}); });