imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve strictNullChecks support in right_panel (#10415)

Browse source
This commit is contained in:
Andy Balaam 2023-03-22 12:15:26 +00:00 • committed by GitHub
parent 853b3f822d
commit ba36d2cc01
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 63 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/views/right_panel/HeaderButtons.tsx
View file

@ -34,7 +34,7 @@ export enum HeaderKind {
interface IState {
headerKind: HeaderKind;
phase: RightPanelPhases;
phase: RightPanelPhases | null;
threadNotificationColor: NotificationColor;
globalNotificationColor: NotificationColor;
}
@ -43,7 +43,7 @@ interface IProps {}
export default abstract class HeaderButtons<P = {}> extends React.Component<IProps & P, IState> {
private unmounted = false;
private dispatcherRef: string;
private dispatcherRef?: string = undefined;
public constructor(props: IProps & P, kind: HeaderKind) {
super(props);
@ -83,7 +83,7 @@ export default abstract class HeaderButtons<P = {}> extends React.Component<IPro
public isPhase(phases: string | string[]): boolean {
if (!RightPanelStore.instance.isOpen) return false;
if (Array.isArray(phases)) {
return phases.includes(this.state.phase);
return !!this.state.phase && phases.includes(this.state.phase);
} else {
return phases === this.state.phase;
}