imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

turn NPE into a throw

Browse source
This commit is contained in:
Matthew Hodgson 2019-04-04 16:53:17 +01:00
parent e98ef0d537
commit b9eebee13b
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/matrix-to.js
View file

@ -239,9 +239,13 @@ export function makeUserPermalink(userId) {
export function makeRoomPermalink(roomId) { export function makeRoomPermalink(roomId) {
const permalinkBase = `${baseUrl}/#/${roomId}`; const permalinkBase = `${baseUrl}/#/${roomId}`;
if (!roomId) {
throw new Error("can't permalink a falsey roomId");
}
// If the roomId isn't actually a room ID, don't try to list the servers. // If the roomId isn't actually a room ID, don't try to list the servers.
// Aliases are already routable, and don't need extra information. // Aliases are already routable, and don't need extra information.
if (!roomId || roomId[0] !== '!') return permalinkBase; if (roomId[0] !== '!') return permalinkBase;
const client = MatrixClientPeg.get(); const client = MatrixClientPeg.get();
const room = client.getRoom(roomId); const room = client.getRoom(roomId);