From 5e5fdb9b9697d039198f63c59254ef9c0b44ebc1 Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Sun, 14 Feb 2016 13:38:12 +0200 Subject: [PATCH 1/5] fix vector-im/vector-web#921 --- src/components/views/elements/TruncatedList.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/views/elements/TruncatedList.js b/src/components/views/elements/TruncatedList.js index 275686c6be..3e174848d3 100644 --- a/src/components/views/elements/TruncatedList.js +++ b/src/components/views/elements/TruncatedList.js @@ -51,7 +51,7 @@ module.exports = React.createClass({ if (this.props.truncateAt >= 0) { var overflowCount = childCount - this.props.truncateAt; - if (overflowCount > 0) { + if (overflowCount > 1) { overflowJsx = this.props.createOverflowElement( overflowCount, childCount ); From 5e407b44b7317d3fe53a03d09287dae8ec1e3dbc Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Sun, 14 Feb 2016 13:45:52 +0200 Subject: [PATCH 2/5] add markdown to tab complete list --- src/SlashCommands.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/SlashCommands.js b/src/SlashCommands.js index d4e7df3a16..fcdd33474e 100644 --- a/src/SlashCommands.js +++ b/src/SlashCommands.js @@ -352,11 +352,12 @@ module.exports = { }, getCommandList: function() { - // Return all the commands plus /me which isn't handled like normal commands + // Return all the commands plus /me and /markdown which aren't handled like normal commands var cmds = Object.keys(commands).sort().map(function(cmdKey) { return commands[cmdKey]; }) cmds.push(new Command("me", "", function(){})); + cmds.push(new Command("markdown", "", function(){})); return cmds; } From 9d3b0f607507190efea0c3d8d1cf504c7b317016 Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Mon, 15 Feb 2016 00:37:59 +0200 Subject: [PATCH 3/5] fix https://github.com/vector-im/vector-web/issues/913 --- src/components/views/rooms/MemberList.js | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/components/views/rooms/MemberList.js b/src/components/views/rooms/MemberList.js index 3cddee8632..4e8f38b035 100644 --- a/src/components/views/rooms/MemberList.js +++ b/src/components/views/rooms/MemberList.js @@ -35,21 +35,23 @@ var invite_defer = q.defer(); module.exports = React.createClass({ displayName: 'MemberList', + getInitialState: function() { - if (!this.props.roomId) return { members: [] }; - var cli = MatrixClientPeg.get(); - var room = cli.getRoom(this.props.roomId); - if (!room) return { members: [] }; - - this.memberDict = this.getMemberDict(); - - var members = this.roomMembers(INITIAL_LOAD_NUM_MEMBERS); - return { - members: members, + var state = { + members: [], // ideally we'd size this to the page height, but // in practice I find that a little constraining truncateAt: INITIAL_LOAD_NUM_MEMBERS, }; + if (!this.props.roomId) return state; + var cli = MatrixClientPeg.get(); + var room = cli.getRoom(this.props.roomId); + if (!room) return state; + + this.memberDict = this.getMemberDict(); + + state.members = this.roomMembers(INITIAL_LOAD_NUM_MEMBERS); + return state; }, componentWillMount: function() { From 0a37f1c4787b2e3a3643dcaeecf946b144d79d34 Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Mon, 15 Feb 2016 09:52:57 +0200 Subject: [PATCH 4/5] improve the fix for https://github.com/vector-im/vector-web/issues/917 --- .../views/rooms/SearchableEntityList.js | 51 ++++++++++--------- 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/src/components/views/rooms/SearchableEntityList.js b/src/components/views/rooms/SearchableEntityList.js index c91e058e4c..fc0446ab41 100644 --- a/src/components/views/rooms/SearchableEntityList.js +++ b/src/components/views/rooms/SearchableEntityList.js @@ -140,34 +140,37 @@ var SearchableEntityList = React.createClass({ } var list; - if (this.props.truncateAt) { // caller wants list truncated - var TruncatedList = sdk.getComponent("elements.TruncatedList"); - list = ( - - {this.state.results.map((entity) => { - return entity.getJsx(); - })} - - ); - } - else { - list = ( -
- {this.state.results.map((entity) => { - return entity.getJsx(); - })} -
- ); + if (this.state.results.length) { + if (this.props.truncateAt) { // caller wants list truncated + var TruncatedList = sdk.getComponent("elements.TruncatedList"); + list = ( + + {this.state.results.map((entity) => { + return entity.getJsx(); + })} + + ); + } + else { + list = ( +
+ {this.state.results.map((entity) => { + return entity.getJsx(); + })} +
+ ); + } + list = + { list } + ; } return (
- {inputBox} - - { list } - + { inputBox } + { list } { this.state.query.length ?

: '' }
); From 0c7573629a4688e0fc58875275e850e557bec31d Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Mon, 15 Feb 2016 11:13:37 +0200 Subject: [PATCH 5/5] spell out that you can invite email addresses --- src/components/views/rooms/InviteMemberList.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/views/rooms/InviteMemberList.js b/src/components/views/rooms/InviteMemberList.js index 73ee4f7c27..480066771b 100644 --- a/src/components/views/rooms/InviteMemberList.js +++ b/src/components/views/rooms/InviteMemberList.js @@ -89,7 +89,7 @@ module.exports = React.createClass({ } return ( -