imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

move Dialog analytics to Modal controller

Browse source 
mark title as required, it sorta is, why isn't this based on BaseDialog?

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski 2017-05-29 17:39:03 +01:00
parent c2dca0c805
commit b65e4960a5
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/components/views/dialogs/BaseDialog.js
View file

@ -16,7 +16,6 @@ limitations under the License.
import React from 'react';
import Analytics from '../../../Analytics';
import * as KeyCode from '../../../KeyCode';
import AccessibleButton from '../elements/AccessibleButton';
import sdk from '../../../index';
@ -67,7 +66,6 @@ export default React.createClass({
},
render: function() {
Analytics.trackEvent('Dialog', this.props.title, 'mount');
const TintableSvg = sdk.getComponent("elements.TintableSvg");
return (

2
src/components/views/dialogs/ChatInviteDialog.js
View file

@ -34,7 +34,7 @@ const TRUNCATE_QUERY_LIST = 40;
module.exports = React.createClass({
displayName: "ChatInviteDialog",
propTypes: {
title: React.PropTypes.string,
title: React.PropTypes.string.isRequired,
description: React.PropTypes.oneOfType([
React.PropTypes.element,
React.PropTypes.string,