Fix visual regressions around widget permissions (#10954)

* Add a Jest snapshot of AppPermission

* Move the test inside 'for a pinned widget' category

* Make only spinner message bold

* Set font size specified with "mx_AppPermission_smallText" by default

- Add "mx_AppPermission_largeText" for elements whose size has not been specified with mx_AppPermission_smallText
- Create _AppWarning.pcss for AppWarning

* Make AppPermission panel scrollable, keeping the content at the center

* Run prettier

* Use Heading component

* Use Icon component

* Fix the test
This commit is contained in:
Suguru Hirahara 2023-06-14 11:11:06 +00:00 committed by GitHub
parent 127b542233
commit b40f29f04c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 251 additions and 70 deletions

View file

@ -16,41 +16,29 @@ limitations under the License.
*/
.mx_AppPermission {
> div {
margin-bottom: 12px;
}
font-size: $font-12px;
width: 100%; /* make mx_AppPermission fill width of mx_AppTileBody so that scroll bar appears on the edge */
overflow-y: scroll;
h4 {
margin: 0;
padding: 0;
}
.mx_AppPermission_content {
margin-block: auto; /* place at the center */
.mx_AppPermission_smallText {
font-size: $font-12px;
}
> div {
margin-block: 12px;
}
.mx_AppPermission_bolder {
font-weight: var(--font-semi-bold);
}
.mx_AppPermission_content_bolder {
font-weight: var(--font-semi-bold);
}
.mx_AppPermission_helpIcon {
margin-top: 1px;
margin-right: 2px;
width: 10px;
height: 10px;
display: inline-block;
&::before {
.mx_TextWithTooltip_target--helpIcon {
display: inline-block;
background-color: $accent;
mask-repeat: no-repeat;
mask-size: 12px;
width: 12px;
height: 12px;
mask-position: center;
content: "";
height: $font-14px; /* align with characters on the same line */
vertical-align: middle;
mask-image: url("$(res)/img/feather-customised/help-circle.svg");
.mx_Icon {
color: $accent;
}
}
}
}

View file

@ -0,0 +1,25 @@
/*
Copyright 2023 Suguru Hirahara
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
.mx_AppWarning {
font-size: $font-16px;
justify-content: center;
h4 {
margin: 0;
padding: 0;
}
}