imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix jest/no-conditional-expect lint and enable it (#10307)

Browse source
This commit is contained in:
Michael Telatynski 2023-03-07 13:58:10 +00:00 • committed by GitHub
parent 2c97cb4054
commit af1ec76149
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 49 additions and 83 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/components/views/rooms/MessageComposer-test.tsx
View file

@ -220,8 +220,10 @@ describe("MessageComposer", () => {
it(`should${value || "not"} display the button`, () => {
if (value) {
// eslint-disable-next-line jest/no-conditional-expect
expect(screen.getByLabelText(buttonLabel)).toBeInTheDocument();
} else {
// eslint-disable-next-line jest/no-conditional-expect
expect(screen.queryByLabelText(buttonLabel)).not.toBeInTheDocument();
}
});
@ -242,8 +244,10 @@ describe("MessageComposer", () => {
it(`should${!value || "not"} display the button`, () => {
if (!value) {
// eslint-disable-next-line jest/no-conditional-expect
expect(screen.getByLabelText(buttonLabel)).toBeInTheDocument();
} else {
// eslint-disable-next-line jest/no-conditional-expect
expect(screen.queryByLabelText(buttonLabel)).not.toBeInTheDocument();
}
});

1
test/components/views/rooms/wysiwyg_composer/components/WysiwygComposer-test.tsx
View file

@ -186,6 +186,7 @@ describe("WysiwygComposer", () => {
await waitFor(() => {
const selection = document.getSelection();
if (selection) {
// eslint-disable-next-line jest/no-conditional-expect
expect(selection.focusNode?.textContent).toEqual("other");
}
});