imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update mx_AppLoading to improve maintainability (#10783)

Browse source 
* Nesting: mx_AppLoading

* Conform class and animation name to the naming policy

* Nesting for maintainability, preventing the rule from becoming an orphan

* Rename the class: mx_AppLoading to mx_AppTile_loading
This commit is contained in:
Suguru Hirahara 2023-05-08 12:38:04 +00:00 • committed by GitHub
parent 631ac742aa
commit aed5fcf64a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/views/elements/AppTile.tsx
View file

@ -573,7 +573,7 @@ export default class AppTile extends React.Component<IProps, IState> {
}
const loadingElement = (
<div className="mx_AppLoading_spinner_fadeIn">
<div className="mx_AppTile_loading_fadeInSpinner">
<Spinner message={_t("Loading…")} />
</div>
);
@ -603,7 +603,7 @@ export default class AppTile extends React.Component<IProps, IState> {
} else if (this.state.initialising || !this.state.isUserProfileReady) {
appTileBody = (
<div
className={appTileBodyClass + (this.state.loading ? "mx_AppLoading" : "")}
className={appTileBodyClass + (this.state.loading ? "mx_AppTile_loading" : "")}
style={appTileBodyStyles}
>
{loadingElement}
@ -619,7 +619,7 @@ export default class AppTile extends React.Component<IProps, IState> {
} else {
appTileBody = (
<div
className={appTileBodyClass + (this.state.loading ? "mx_AppLoading" : "")}
className={appTileBodyClass + (this.state.loading ? "mx_AppTile_loading" : "")}
style={appTileBodyStyles}
>
{this.state.loading && loadingElement}