Let TimelinePanel not send a receipt if there is no event (#10912)

This commit is contained in:
Michael Weimann 2023-05-16 13:34:59 +02:00 committed by GitHub
parent da0f072ed9
commit acdbae3e8c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 2 deletions

View file

@ -1082,7 +1082,9 @@ class TimelinePanel extends React.Component<IProps, IState> {
currentReadReceiptEventIndex: number | null,
lastReadEvent: MatrixEvent | null,
lastReadEventIndex: number | null,
): boolean {
): lastReadEvent is MatrixEvent {
if (!lastReadEvent) return false;
// We want to avoid sending out read receipts when we are looking at
// events in the past which are before the latest RR.
//
@ -1133,7 +1135,7 @@ class TimelinePanel extends React.Component<IProps, IState> {
const lastReadEventIndex = this.getLastDisplayedEventIndex({
ignoreOwn: true,
});
const lastReadEvent: MatrixEvent | null = this.state.events[lastReadEventIndex ?? 0];
const lastReadEvent: MatrixEvent | null = this.state.events[lastReadEventIndex ?? 0] ?? null;
const shouldSendReadReceipt = this.shouldSendReadReceipt(
currentReadReceiptEventId,