imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

more consistent naming on session methods

Browse source
This commit is contained in:
Bruno Windels 2018-08-07 18:21:53 +02:00
parent 4e7df2126b
commit aaa5ee1a25
7 changed files with 52 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/session.js
View file

@ -129,15 +129,22 @@ module.exports = class RiotSession {
await input.type(text);
}
// TODO: rename to waitAndQuery(Single)?
async waitAndQuerySelector(selector, timeout = 500) {
query(selector) {
return this.page.$(selector);
}
async waitAndQuery(selector, timeout = 500) {
await this.page.waitForSelector(selector, {visible: true, timeout});
return await this.page.$(selector);
return await this.query(selector);
}
queryAll(selector) {
return this.page.$$(selector);
}
async waitAndQueryAll(selector, timeout = 500) {
await this.page.waitForSelector(selector, {visible: true, timeout});
return await this.page.$$(selector);
return await this.queryAll(selector);
}
waitForNewPage(timeout = 500) {
@ -157,15 +164,11 @@ module.exports = class RiotSession {
});
}
waitForSelector(selector) {
return this.page.waitForSelector(selector);
}
goto(url) {
return this.page.goto(url);
}
riotUrl(path) {
url(path) {
return this.riotserver + path;
}