imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add some tolerances to breadcrumb scrolling

Browse source 
See https://github.com/vector-im/riot-web/issues/9400
See https://github.com/vector-im/riot-web/issues/9394

Tolerances are defined as a device-only setting to give advanced users an option to override the values. No UI is exposed for this. 

The default values are picked for assumptions on comfort, however as people change the tolerances themselves the defaults may need to change.
This commit is contained in:
Travis Ralston 2019-04-08 10:53:09 -06:00
parent 054011f5f8
commit aa96fd27cc
3 changed files with 36 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/components/views/rooms/RoomBreadcrumbs.js
View file

@ -33,7 +33,13 @@ const MAX_ROOMS = 20;
export default class RoomBreadcrumbs extends React.Component {
constructor(props) {
super(props);
this.state = {rooms: []};
const tolerances = SettingsStore.getValue("breadcrumb_scroll_tolerances");
this.state = {rooms: [], scrollTolerances: tolerances};
// Record this for debugging purposes
console.log("Breadcrumbs scroll tolerances:", tolerances);
this.onAction = this.onAction.bind(this);
this._dispatcherRef = null;
}
@ -334,7 +340,8 @@ export default class RoomBreadcrumbs extends React.Component {
});
return (
<IndicatorScrollbar ref="scroller" className="mx_RoomBreadcrumbs"
trackHorizontalOverflow={true} verticalScrollsHorizontally={true}>
trackHorizontalOverflow={true} verticalScrollsHorizontally={true}
scrollTolerances={this.state.scrollTolerances}>
{ avatars }
</IndicatorScrollbar>
);