Remove feature_custom_status

Rationale: It's legacy and wrong in so many ways.

src/components/views/right_panel/UserInfo.tsx

@@ -75,7 +75,6 @@ import { UIComponent } from "../../../settings/UIFeature";
 import { TimelineRenderingType } from "../../../contexts/RoomContext";
 import RightPanelStore from '../../../stores/right-panel/RightPanelStore';
 import { IRightPanelCardState } from '../../../stores/right-panel/RightPanelStoreIPanelState';
-import { useUserStatusMessage } from "../../../hooks/useUserStatusMessage";
 import UserIdentifierCustomisations from '../../../customisations/UserIdentifier';
 import PosthogTrackers from "../../../PosthogTrackers";
 import { ViewRoomPayload } from "../../../dispatcher/payloads/ViewRoomPayload";
@@ -1411,7 +1410,6 @@ const UserInfoHeader: React.FC<{
     roomId?: string;
 }> = ({ member, e2eStatus, roomId }) => {
     const cli = useContext(MatrixClientContext);
-    const statusMessage = useUserStatusMessage(member);
 
     const onMemberAvatarClick = useCallback(() => {
         const avatarUrl = (member as RoomMember).getMxcAvatarUrl
@@ -1472,11 +1470,6 @@ const UserInfoHeader: React.FC<{
         );
     }
 
-    let statusLabel = null;
-    if (statusMessage) {
-        statusLabel = <span className="mx_UserInfo_statusMessage">{ statusMessage }</span>;
-    }
-
     let e2eIcon;
     if (e2eStatus) {
         e2eIcon = <E2EIcon size={18} status={e2eStatus} isUser={true} />;
@@ -1499,7 +1492,6 @@ const UserInfoHeader: React.FC<{
                 <div>{ UserIdentifierCustomisations.getDisplayUserIdentifier(member.userId, { roomId, withDisplayName: true }) }</div>
                 <div className="mx_UserInfo_profileStatus">
                     { presenceLabel }
-                    { statusLabel }
                 </div>
             </div>
         </div>

src/components/views/rooms/MemberTile.tsx

@@ -20,12 +20,10 @@ import { RoomMember } from "matrix-js-sdk/src/models/room-member";
 import { MatrixEvent } from "matrix-js-sdk/src/models/event";
 import { EventType } from "matrix-js-sdk/src/@types/event";
 import { DeviceInfo } from "matrix-js-sdk/src/crypto/deviceinfo";
-import { UserEvent } from "matrix-js-sdk/src/models/user";
 import { CryptoEvent } from "matrix-js-sdk/src/crypto";
 import { RoomStateEvent } from "matrix-js-sdk/src/models/room-state";
 import { UserTrustLevel } from 'matrix-js-sdk/src/crypto/CrossSigning';
 
-import SettingsStore from "../../../settings/SettingsStore";
 import dis from "../../../dispatcher/dispatcher";
 import { _t } from '../../../languageHandler';
 import { MatrixClientPeg } from "../../../MatrixClientPeg";
@@ -41,7 +39,6 @@ interface IProps {
 }
 
 interface IState {
-    statusMessage: string;
     isRoomEncrypted: boolean;
     e2eStatus: string;
 }
@@ -58,7 +55,6 @@ export default class MemberTile extends React.Component<IProps, IState> {
         super(props);
 
         this.state = {
-            statusMessage: this.getStatusMessage(),
             isRoomEncrypted: false,
             e2eStatus: null,
         };
@@ -67,13 +63,6 @@ export default class MemberTile extends React.Component<IProps, IState> {
     componentDidMount() {
         const cli = MatrixClientPeg.get();
 
-        if (SettingsStore.getValue("feature_custom_status")) {
-            const { user } = this.props.member;
-            if (user) {
-                user.on(UserEvent._UnstableStatusMessage, this.onStatusMessageCommitted);
-            }
-        }
-
         const { roomId } = this.props.member;
         if (roomId) {
             const isRoomEncrypted = cli.isRoomEncrypted(roomId);
@@ -94,11 +83,6 @@ export default class MemberTile extends React.Component<IProps, IState> {
     componentWillUnmount() {
         const cli = MatrixClientPeg.get();
 
-        const { user } = this.props.member;
-        if (user) {
-            user.removeListener(UserEvent._UnstableStatusMessage, this.onStatusMessageCommitted);
-        }
-
         if (cli) {
             cli.removeListener(RoomStateEvent.Events, this.onRoomStateEvents);
             cli.removeListener(CryptoEvent.UserTrustStatusChanged, this.onUserTrustStatusChanged);
@@ -158,21 +142,6 @@ export default class MemberTile extends React.Component<IProps, IState> {
         });
     }
 
-    private getStatusMessage(): string {
-        const { user } = this.props.member;
-        if (!user) {
-            return "";
-        }
-        return user.unstable_statusMessage;
-    }
-
-    private onStatusMessageCommitted = (): void => {
-        // The `User` object has observed a status message change.
-        this.setState({
-            statusMessage: this.getStatusMessage(),
-        });
-    };
-
     shouldComponentUpdate(nextProps: IProps, nextState: IState): boolean {
         if (
             this.memberLastModifiedTime === undefined ||
@@ -222,11 +191,6 @@ export default class MemberTile extends React.Component<IProps, IState> {
         const name = this.getDisplayName();
         const presenceState = member.user ? member.user.presence : null;
 
-        let statusMessage = null;
-        if (member.user && SettingsStore.getValue("feature_custom_status")) {
-            statusMessage = this.state.statusMessage;
-        }
-
         const av = (
             <MemberAvatar member={member} width={36} height={36} aria-hidden="true" />
         );
@@ -277,7 +241,6 @@ export default class MemberTile extends React.Component<IProps, IState> {
                 nameJSX={nameJSX}
                 powerStatus={powerStatus}
                 showPresence={this.props.showPresence}
-                subtextLabel={statusMessage}
                 e2eStatus={e2eStatus}
                 onClick={this.onClick}
             />