imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Lint MXC APIs to centralise access

Browse source 
This adds linting rules to ensure that MXC APIs are only accessed via the
`Media` helper so they can be customised easily when desired.

Fixes https://github.com/vector-im/element-web/issues/16933
This commit is contained in:
J. Ryan Stinnett 2021-06-30 14:19:39 +01:00
parent 6b8c38af3a
commit a9f35e8c69
2 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
.eslintrc.js
View file

@ -54,7 +54,11 @@ module.exports = {
"error",
...buildRestrictedPropertiesOptions(
["window.innerHeight", "window.innerWidth", "window.visualViewport"],
"Use UIStore to access window dimensions instead",
"Use UIStore to access window dimensions instead.",
),
...buildRestrictedPropertiesOptions(
["*.mxcUrlToHttp", "*.getHttpUriForMxc"],
"Use Media helper instead to centralise access for customisation.",
),
],
},
@ -63,7 +67,10 @@ module.exports = {
function buildRestrictedPropertiesOptions(properties, message) {
return properties.map(prop => {
const [object, property] = prop.split(".");
let [object, property] = prop.split(".");
if (object === "*") {
object = undefined;
}
return {
object,
property,