Use strong over b for improved a11y semantics

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski 2024-09-13 12:09:41 +01:00
parent 6b384fe9c1
commit a6e98b0b63
No known key found for this signature in database
GPG key ID: A2B008A5F49F5D0D
35 changed files with 80 additions and 66 deletions

View file

@ -78,7 +78,7 @@ export default class CryptographyPanel extends React.Component<IProps, IState> {
<th scope="row">{_t("settings|security|session_key")}</th>
<td>
<code>
<b>{identityKey}</b>
<strong>{identityKey}</strong>
</code>
</td>
</tr>

View file

@ -281,7 +281,7 @@ const JoinRuleSettings: React.FC<JoinRuleSettingsProps> = ({
"room_settings|security|join_rule_restricted_description_active_space",
{},
{
spaceName: () => <b>{SpaceStore.instance.activeSpaceRoom!.name}</b>,
spaceName: () => <strong>{SpaceStore.instance.activeSpaceRoom!.name}</strong>,
},
);
} else {
@ -349,7 +349,7 @@ const JoinRuleSettings: React.FC<JoinRuleSettingsProps> = ({
(roomId) => !cli.getRoom(roomId)?.currentState.maySendStateEvent(EventType.SpaceChild, userId),
);
if (unableToUpdateSomeParents) {
warning = <b>{_t("room_settings|security|join_rule_restricted_upgrade_warning")}</b>;
warning = <strong>{_t("room_settings|security|join_rule_restricted_upgrade_warning")}</strong>;
}
upgradeRequiredDialog(

View file

@ -259,7 +259,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
statusDescription = (
<>
<SettingsSubsectionText>
{_t("settings|security|key_backup_inactive", {}, { b: (sub) => <b>{sub}</b> })}
{_t("settings|security|key_backup_inactive", {}, { b: (sub) => <strong>{sub}</strong> })}
</SettingsSubsectionText>
<SettingsSubsectionText>
{_t("settings|security|key_backup_connect_prompt")}
@ -336,7 +336,11 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
statusDescription = (
<>
<SettingsSubsectionText>
{_t("settings|security|key_backup_inactive_warning", {}, { b: (sub) => <b>{sub}</b> })}
{_t(
"settings|security|key_backup_inactive_warning",
{},
{ b: (sub) => <strong>{sub}</strong> },
)}
</SettingsSubsectionText>
<SettingsSubsectionText>{_t("encryption|setup_secure_backup|explainer")}</SettingsSubsectionText>
</>

View file

@ -188,8 +188,8 @@ export default class SetIdServer extends React.Component<IProps, IState> {
"identity_server|change_prompt",
{},
{
current: (sub) => <b>{abbreviateUrl(currentClientIdServer)}</b>,
new: (sub) => <b>{abbreviateUrl(idServer)}</b>,
current: (sub) => <strong>{abbreviateUrl(currentClientIdServer)}</strong>,
new: (sub) => <strong>{abbreviateUrl(idServer)}</strong>,
},
),
button: _t("action|continue"),
@ -235,7 +235,7 @@ export default class SetIdServer extends React.Component<IProps, IState> {
unboundMessage: _t(
"identity_server|disconnect_server",
{},
{ idserver: (sub) => <b>{abbreviateUrl(this.state.currentClientIdServer)}</b> },
{ idserver: (sub) => <strong>{abbreviateUrl(this.state.currentClientIdServer)}</strong> },
),
button: _t("action|disconnect"),
});
@ -278,8 +278,8 @@ export default class SetIdServer extends React.Component<IProps, IState> {
let message;
let danger = false;
const messageElements = {
idserver: (sub: string) => <b>{abbreviateUrl(currentClientIdServer)}</b>,
b: (sub: string) => <b>{sub}</b>,
idserver: (sub: string) => <strong>{abbreviateUrl(currentClientIdServer)}</strong>,
b: (sub: string) => <strong>{sub}</strong>,
};
if (!currentServerReachable) {
message = (
@ -356,13 +356,13 @@ export default class SetIdServer extends React.Component<IProps, IState> {
bodyText = _t(
"identity_server|description_connected",
{},
{ server: (sub) => <b>{abbreviateUrl(idServerUrl)}</b> },
{ server: (sub) => <strong>{abbreviateUrl(idServerUrl)}</strong> },
);
if (this.props.missingTerms) {
bodyText = _t(
"identity_server|change_server_prompt",
{},
{ server: (sub) => <b>{abbreviateUrl(idServerUrl)}</b> },
{ server: (sub) => <strong>{abbreviateUrl(idServerUrl)}</strong> },
);
}
} else {

View file

@ -58,7 +58,7 @@ export default class SetIntegrationManager extends React.Component<IProps, IStat
bodyText = _t(
"integration_manager|use_im_default",
{ serverName: currentManager.name },
{ b: (sub) => <b>{sub}</b> },
{ b: (sub) => <strong>{sub}</strong> },
);
} else {
bodyText = _t("integration_manager|use_im");

View file

@ -115,7 +115,7 @@ export default class AdvancedRoomSettingsTab extends React.Component<IProps, ISt
"room_settings|advanced|room_upgrade_warning",
{},
{
b: (sub) => <b>{sub}</b>,
b: (sub) => <strong>{sub}</strong>,
i: (sub) => <i>{sub}</i>,
},
)}

View file

@ -117,7 +117,7 @@ export default class SecurityRoomSettingsTab extends React.Component<IProps, ISt
{_t(
"room_settings|security|enable_encryption_public_room_confirm_description_1",
undefined,
{ b: (sub) => <b>{sub}</b> },
{ b: (sub) => <strong>{sub}</strong> },
)}{" "}
</p>
<p>
@ -308,7 +308,7 @@ export default class SecurityRoomSettingsTab extends React.Component<IProps, ISt
<p>
{" "}
{_t("room_settings|security|encrypted_room_public_confirm_description_1", undefined, {
b: (sub) => <b>{sub}</b>,
b: (sub) => <strong>{sub}</strong>,
})}{" "}
</p>
<p>

View file

@ -302,7 +302,7 @@ export default class HelpUserSettingsTab extends React.Component<IProps, IState>
<summary className="mx_HelpUserSettingsTab_accessTokenDetails">
{_t("common|access_token")}
</summary>
<b>{_t("setting|help_about|access_token_detail")}</b>
<strong>{_t("setting|help_about|access_token_detail")}</strong>
<CopyableText getTextToCopy={() => this.context.getAccessToken()}>
{this.context.getAccessToken()}
</CopyableText>