imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve quality of Typescript types (#10742)

Browse source
This commit is contained in:
Michael Telatynski 2023-05-05 09:11:14 +01:00 • committed by GitHub
parent 542bf68c63
commit a4f0b80692
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 74 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/utils/LazyValue.ts
View file

@ -18,8 +18,8 @@ limitations under the License.
* Utility class for lazily getting a variable.
*/
export class LazyValue<T> {
private val: T;
private prom: Promise<T>;
private val?: T;
private prom?: Promise<T>;
private done = false;
public constructor(private getFn: () => Promise<T>) {}
@ -36,7 +36,7 @@ export class LazyValue<T> {
* Gets the value without invoking a get. May be undefined until the
* value is fetched properly.
*/
public get cachedValue(): T {
public get cachedValue(): T | undefined {
return this.val;
}

16
src/utils/ValidatedServerConfig.ts
View file

@ -14,16 +14,16 @@ See the License for the specific language governing permissions and
limitations under the License.
*/
export class ValidatedServerConfig {
public hsUrl: string;
public hsName: string;
public hsNameIsDifferent: boolean;
export interface ValidatedServerConfig {
hsUrl: string;
hsName: string;
hsNameIsDifferent: boolean;
public isUrl: string;
isUrl: string;
public isDefault: boolean;
isDefault: boolean;
// when the server config is based on static URLs the hsName is not resolvable and things may wish to use hsUrl
public isNameResolvable: boolean;
isNameResolvable: boolean;
public warning: string | Error;
warning: string | Error;
}