imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

only pass keyboard to autocomplete when it has selections

Browse source 
otherwise if tab is pressed, try to tab complete the last word
This commit is contained in:
Bruno Windels 2019-09-02 11:25:29 +02:00
parent 4779880a94
commit a4376a76f0
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/components/views/rooms/BasicMessageComposer.js
View file

@ -265,7 +265,7 @@ export default class BasicMessageEditor extends React.Component {
handled = true; handled = true;
// autocomplete or enter to send below shouldn't have any modifier keys pressed. // autocomplete or enter to send below shouldn't have any modifier keys pressed.
} else if (!(event.metaKey || event.altKey || event.shiftKey)) { } else if (!(event.metaKey || event.altKey || event.shiftKey)) {
if (model.autoComplete) { if (model.autoComplete && model.autoComplete.hasCompletions()) {
const autoComplete = model.autoComplete; const autoComplete = model.autoComplete;
switch (event.key) { switch (event.key) {
case "ArrowUp": case "ArrowUp":

5
src/editor/autocomplete.js
View file

@ -41,6 +41,11 @@ export default class AutocompleteWrapperModel {
return this._getAutocompleterComponent().hasSelection(); return this._getAutocompleterComponent().hasSelection();
} }
hasCompletions() {
const ac = this._getAutocompleterComponent();
return ac && ac.countCompletions() > 0;
}
onEnter() { onEnter() {
this._updateCallback({close: true}); this._updateCallback({close: true});
} }