Merge pull request #9320 from matrix-org/florianduros/fix-white-black-theme-switch

Fix dark and white theme switch in Chrome
This commit is contained in:
Florian Duros 2022-10-07 09:40:12 +02:00 committed by GitHub
commit a11c1e17a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 167 additions and 27 deletions

115
test/theme-test.ts Normal file
View file

@ -0,0 +1,115 @@
/*
Copyright 2022 The Matrix.org Foundation C.I.C.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
import { setTheme } from "../src/theme";
describe('theme', () => {
describe('setTheme', () => {
let lightTheme;
let darkTheme;
let spyQuerySelectorAll: jest.MockInstance<NodeListOf<Element>, [selectors: string]>;
beforeEach(() => {
const styles = [
{
attributes: {
'data-mx-theme': {
value: 'light',
},
},
disabled: true,
href: 'urlLight',
onload: () => void 0,
},
{
attributes: {
'data-mx-theme': {
value: 'dark',
},
},
disabled: true,
href: 'urlDark',
onload: () => void 0,
},
];
lightTheme = styles[0];
darkTheme = styles[1];
jest.spyOn(document.body, 'style', 'get').mockReturnValue([] as any);
spyQuerySelectorAll = jest.spyOn(document, 'querySelectorAll').mockReturnValue(styles as any);
});
afterEach(() => {
jest.restoreAllMocks();
jest.useRealTimers();
});
it('should switch theme on onload call', async () => {
// When
await new Promise(resolve => {
setTheme('light').then(resolve);
lightTheme.onload();
});
// Then
expect(spyQuerySelectorAll).toHaveBeenCalledWith('[data-mx-theme]');
expect(spyQuerySelectorAll).toBeCalledTimes(1);
expect(lightTheme.disabled).toBe(false);
expect(darkTheme.disabled).toBe(true);
});
it('should reject promise on onerror call', () => {
return expect(new Promise(resolve => {
setTheme('light').catch(e => resolve(e));
lightTheme.onerror('call onerror');
})).resolves.toBe('call onerror');
});
it('should switch theme if CSS are preloaded', async () => {
// When
jest.spyOn(document, 'styleSheets', 'get').mockReturnValue([lightTheme] as any);
await setTheme('light');
// Then
expect(lightTheme.disabled).toBe(false);
expect(darkTheme.disabled).toBe(true);
});
it('should switch theme if CSS is loaded during pooling', async () => {
// When
jest.useFakeTimers();
await new Promise(resolve => {
setTheme('light').then(resolve);
jest.spyOn(document, 'styleSheets', 'get').mockReturnValue([lightTheme] as any);
jest.advanceTimersByTime(200);
});
// Then
expect(lightTheme.disabled).toBe(false);
expect(darkTheme.disabled).toBe(true);
});
it('should reject promise if pooling maximum value is reached', () => {
jest.useFakeTimers();
return new Promise(resolve => {
setTheme('light').catch(resolve);
jest.advanceTimersByTime(200 * 10);
});
});
});
});